Adds HubUtility to resolve hub names. #130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeps HubContext name resolution consistent with OrleansHubLifetimeManager.
I understand this could be breaking to some consumers of the library. However, I thought Id' raise the PR to get the conversation going.
In my opinion, the OrleansHubLifetimeManager should not look for the typed client of the hub when resolving the hub name but maybe I am missing something.
I've also brought the HubContext in line with the actual implementation of hub context which will ensure consistency between the HubContext and OrleansHubLifetimeManager.
From MSDN:
public interface IHubContext<out THub> where THub : Hub
Ref:
https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnetcore.signalr.ihubcontext-1?view=aspnetcore-6.0