Standardised saveButtons and reference labels properly

OrtooApps · Jan 11, 2022 · 141f1ef · 141f1ef
1 parent 19322de
commit 141f1ef
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 14 deletions.
diff --git a/framework/default/ortoo-core/default/lwc/saveButtons/saveButtons.css b/framework/default/ortoo-core/default/lwc/saveButtons/saveButtons.css
diff --git a/framework/default/ortoo-core/default/lwc/saveButtons/saveButtons.html b/framework/default/ortoo-core/default/lwc/saveButtons/saveButtons.html
@@ -4,8 +4,6 @@
         class="slds-p-around_xxx-small"
         data-ortoo-elem-id={cancelButtonId}
         variant="default"
-        name="cancel"
-        data-name="cancel"
         label={cancelLabel}
         onclick={handleCancelClick}
     ></lightning-button>
@@ -16,8 +14,6 @@
         class="slds-p-around_xxx-small"
         data-ortoo-elem-id={saveButtonId}
         variant="brand"
-        name="save"
-        data-name="save"
         label={saveLabel}
         onclick={handleSaveClick}
     ></lightning-button>

diff --git a/framework/default/ortoo-core/default/lwc/saveButtons/saveButtons.js b/framework/default/ortoo-core/default/lwc/saveButtons/saveButtons.js
@@ -1,15 +1,20 @@
 import { LightningElement, api } from 'lwc';
 import configureElementIdGenerator from 'c/elementIdGenerator';
 
-//import CANCEL_LABEL from '@salesforce/label/c.ortoo_core_cancel';
-//import SAVE_LABEL from '@salesforce/label/c.ortoo_core_save';
-
-const CANCEL_LABEL = 'Cancel';
-const SAVE_LABEL = 'Save';
+import CANCEL_LABEL from '@salesforce/label/c.ortoo_core_cancel';
+import SAVE_LABEL from '@salesforce/label/c.ortoo_core_save';
+
+/**
+ * Provides a standard format for save and cancel buttons, as well as the ability to add additional ones into it.
+ *
+ * If the 'additional-buttons' slot is used, it should be used with:
+ *      * <span slot="additional-buttons">
+ *      * Buttons that have class="slds-p-around_xxx-small"
+ */
 export default class SaveButtons extends LightningElement {
 
-    @api cancelLabel = CANCEL_LABEL; // should be a label (see above)
-    @api saveLabel   = SAVE_LABEL; // should be a label (see above)
+    @api cancelLabel = CANCEL_LABEL;
+    @api saveLabel   = SAVE_LABEL;
 
     @api ortooElemIdPrefix = 'savebuttons';