Moved reference in test from aria-id to data-name in order to introdu…

…ce a standard Improved testing of the confirmation dialog
OrtooApps · Dec 13, 2021 · 18d97f8 · 18d97f8
1 parent 62ea46a
commit 18d97f8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/framework/default/ortoo-core/default/lwc/modal/__tests__/modal.test.js b/framework/default/ortoo-core/default/lwc/modal/__tests__/modal.test.js
@@ -100,7 +100,7 @@ describe('c-modal', () => {
         return Promise.resolve()
             .then( () => {
                 const clickEvent = new CustomEvent( 'click', {} );
-                return element.shadowRoot.querySelector( 'button[aria-id="cancel-cross"]' ).dispatchEvent( clickEvent );
+                return element.shadowRoot.querySelector( 'button[data-name="cancel-cross"]' ).dispatchEvent( clickEvent );
             })
             .then( () => {
                 expect( cancelHandler ).toHaveBeenCalled();

diff --git a/framework/default/ortoo-core/default/lwc/modal/modal.html b/framework/default/ortoo-core/default/lwc/modal/modal.html
@@ -17,7 +17,7 @@
                             class="slds-button slds-button_icon slds-modal__close slds-button_icon-inverse"
                             title={labels.close}
                             onclick={handleCancel}
-                            aria-id="cancel-cross"
+                            data-name="cancel-cross"
                         >
                             <lightning-icon
                                 icon-name="utility:close"