Improved output of inaccessible fields on security violation

OrtooApps · Mar 30, 2022 · 5e008f5 · 5e008f5
1 parent 62b2089
commit 5e008f5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/framework/default/ortoo-core/default/classes/fflib-extension/SecureDml.cls b/framework/default/ortoo-core/default/classes/fflib-extension/SecureDml.cls
@@ -617,8 +617,9 @@ public inherited sharing virtual class SecureDml extends fflib_SobjectUnitOfWork
 			String label = Label.ortoo_core_fls_violation;
 			String modeDescription = descriptionByMode.get( mode );
 			String sobjectTypeName = SobjectUtils.getSobjectName( sobjectType );
+			String fieldsInViolationString = String.join( ListUtils.convertToListOfStrings( fieldsInViolation ), ', ' );
 
-			throw new SecureDmlException( StringUtils.formatLabel( label, new List<String>{ modeDescription, sobjectTypeName, fieldsInViolation.toString() } ) )
+			throw new SecureDmlException( StringUtils.formatLabel( label, new List<String>{ modeDescription, sobjectTypeName, fieldsInViolationString } ) )
 						.setErrorCode( FrameworkErrorCodes.DML_ON_INACCESSIBLE_FIELDS )
 						.addContext( 'sobjectTypeName', sobjectTypeName )
 						.addContext( 'fieldsInViolation', fieldsInViolation )

diff --git a/framework/default/ortoo-core/default/labels/ortoo-core-CustomLabels.labels-meta.xml b/framework/default/ortoo-core/default/labels/ortoo-core-CustomLabels.labels-meta.xml
@@ -33,7 +33,7 @@
         <language>en_US</language>
         <protected>false</protected>
         <shortDescription>Message when FLS violation occurs on a DML operation.</shortDescription>
-        <value>Attempted to {0} {1} with fields that are not accessible: {2}</value>
+        <value>Attempted to {0} {1} with fields that are not accessible / updateable: {2}</value>
     </labels>
     <labels>
         <fullName>ortoo_core_crud_insert_violation</fullName>