Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make editor work in IE8 #4

Closed
OscarGodson opened this issue Feb 18, 2012 · 12 comments
Closed

Make editor work in IE8 #4

OscarGodson opened this issue Feb 18, 2012 · 12 comments
Assignees
Labels
Milestone

Comments

@OscarGodson
Copy link
Owner

No description provided.

@OscarGodson
Copy link
Owner Author

Holy shit. This is actually going to finally happen 6 months later. It's getting closer. Prepare for IE8 support! WHEE

@ghost ghost assigned OscarGodson Aug 9, 2012
OscarGodson added a commit that referenced this issue Aug 12, 2012
…bject' in IE8 during the <base> tag insert
OscarGodson added a commit that referenced this issue Aug 12, 2012
OscarGodson added a commit that referenced this issue Aug 12, 2012
@OscarGodson
Copy link
Owner Author

Closer. If you pull the feature/ticket-4 branch youll see IE8 "works" now. Its janky, but wont crash anything and no more JS errors. Here's whats left:

  1. The editor is misplaced

  1. New lines are lost or wrong upon refreshing.

  2. You can't see the preview and fullscreen buttons.

  3. Keyboard shortcuts arent working at all.

@nathancarnes
Copy link

@OscarGodson: started working on this, and have a few questions.

Editor misplacement -- are you seeing that in the docs example? I'm not able to repro in IE8.

Buttons -- dug into this, and it looks like a JS event issue, not a CSS issue. Regardless of focus/hover state, #epiceditor-utilbar is set to display: none; using an inline style (so, presumably using .hide(), although I haven't dug into the JS yet. I'm able to reproduce this in IE9 also.

If you manually remove that style, the buttons show correctly in both 8 and 9 for me.

@OscarGodson
Copy link
Owner Author

Yes. I'm seeing this in the docs. I didn't make a new test page. Maybe it's just something on the docs' CSS and that's why I haven't been able to figure it out?

If you get an object required error on the utility bar see my fixes for that issue in IE above. But basically a one line fix at the top of the event handler:

function someEventHandler () {
  // Need this for IE:
  e = e || self.iframeElement.contentWindow;

  // codez...
}

@OscarGodson
Copy link
Owner Author

@nathancarnes Did you ever make any progress on anything?

@nathancarnes
Copy link

@OscarGodson -- haven't had time to dig into the JS yet on the button
issue, and I'm not able to reproduce the editor positioning issue, so I'm
kind of at a standstill right now.

@OscarGodson
Copy link
Owner Author

So when you open the site in IE8 the editor isn't funky? Are you checking in native IE8 or virtual IE8 from IE9+?

@nathancarnes
Copy link

Right, the buttons don't work, but the placement issue isn't there.

Virtual IE8 from 9.

@OscarGodson
Copy link
Owner Author

I wonder if that's why. I'm using native IE8. UGH. I HATE IE.

@nathancarnes
Copy link

If I remember correctly, the virtual IE8 in newer version is a
Frankenstein's monster of 8's CSS rendering and 9/10's JS engine.

So that's fun.

OscarGodson added a commit that referenced this issue Nov 14, 2012
@OscarGodson
Copy link
Owner Author

Fixed the positioning issue in IE8. Was happening even on a page with no CSS. It was a simple fix tho. See f3d5c8c

jeremybenaim added a commit to jeremybenaim/EpicEditor that referenced this issue Nov 15, 2012
OscarGodson added a commit that referenced this issue Nov 15, 2012
…for real

Revert "Ticket #4 - Added fix for editor themes for IE8 when in editing mode there would be a white gap to the left"

This reverts commit f3d5c8c.
@OscarGodson
Copy link
Owner Author

Unless I get a lot of people asking for this, I'm going to close this. IE8 is already barely being used anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants