-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make editor work in IE8 #4
Comments
Holy shit. This is actually going to finally happen 6 months later. It's getting closer. Prepare for IE8 support! WHEE |
…bject' in IE8 during the <base> tag insert
…nd remove the IE previewer height hack
Closer. If you pull the
|
@OscarGodson: started working on this, and have a few questions. Editor misplacement -- are you seeing that in the docs example? I'm not able to repro in IE8. Buttons -- dug into this, and it looks like a JS event issue, not a CSS issue. Regardless of focus/hover state, If you manually remove that style, the buttons show correctly in both 8 and 9 for me. |
Yes. I'm seeing this in the docs. I didn't make a new test page. Maybe it's just something on the docs' CSS and that's why I haven't been able to figure it out? If you get an object required error on the utility bar see my fixes for that issue in IE above. But basically a one line fix at the top of the event handler: function someEventHandler () {
// Need this for IE:
e = e || self.iframeElement.contentWindow;
// codez...
} |
@nathancarnes Did you ever make any progress on anything? |
@OscarGodson -- haven't had time to dig into the JS yet on the button |
So when you open the site in IE8 the editor isn't funky? Are you checking in native IE8 or virtual IE8 from IE9+? |
Right, the buttons don't work, but the placement issue isn't there. Virtual IE8 from 9. |
I wonder if that's why. I'm using native IE8. UGH. I HATE IE. |
If I remember correctly, the virtual IE8 in newer version is a So that's fun. |
…there would be a white gap to the left
Fixed the positioning issue in IE8. Was happening even on a page with no CSS. It was a simple fix tho. See f3d5c8c |
Unless I get a lot of people asking for this, I'm going to close this. IE8 is already barely being used anymore. |
No description provided.
The text was updated successfully, but these errors were encountered: