Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localization and dep changes #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

localization and dep changes #21

wants to merge 2 commits into from

Conversation

hanorine
Copy link

When cloning this repo and installing dependencies, the entire OscarYuen/go-graphql-starter is downloaded unnecessarily into vendor. By removing this dependency and having the project look for the packages locally, then changes can be gradually introduced and the project starter can be used to build as one cohesive project. Otherwise, it will be necessary to continually update the online repo and then pulling those changes to local vendor folder.

Build in Golang context can now be imported simply as "context", the changes reflect this.

The dataloader package has been since included into graph-gophers and import reflects this as well.

I have run the graphiql and verified that setup with PostgresQL db works accordingly.

It is best to try out the changes before merging to master.

I hope this can better illustrate for new comers how to properly utilize the graph-gophers implementation in an updated version. Example applications can better serve if they reflect current versions.

Noam Gabriel Jacobson added 2 commits December 29, 2018 12:57
tidied the import blocks.
using dataloader from graph-gophers.
@OscarYuen
Copy link
Owner

@JaysQubeXon Thanks for contribution. I would help take a look on this very soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants