Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cloning this repo and installing dependencies, the entire
OscarYuen/go-graphql-starter
is downloaded unnecessarily into vendor. By removing this dependency and having the project look for the packages locally, then changes can be gradually introduced and the project starter can be used to build as one cohesive project. Otherwise, it will be necessary to continually update the online repo and then pulling those changes to local vendor folder.Build in Golang context can now be imported simply as
"context"
, the changes reflect this.The dataloader package has been since included into graph-gophers and import reflects this as well.
I have run the graphiql and verified that setup with PostgresQL db works accordingly.
It is best to try out the changes before merging to master.
I hope this can better illustrate for new comers how to properly utilize the graph-gophers implementation in an updated version. Example applications can better serve if they reflect current versions.