Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ao_pipewire fixes and media control #1

Closed
wants to merge 3 commits into from

Conversation

t-8ch
Copy link

@t-8ch t-8ch commented Jun 7, 2021

No description provided.

@t-8ch
Copy link
Author

t-8ch commented Jun 10, 2021

FYI @Oschowa

@Oschowa
Copy link
Owner

Oschowa commented Jun 10, 2021

Looks good. FWIW, i've noticed that the current pipewire backend here has issues i haven't figured out yet. The most prominent one is that there is significantly more frame judder or repeated frames with the default --video-sync=audio than with the ALSA backend on pipewire. So i'm not going to PR anything to mpv before i figure that out; might take a look this weekend, but if you can reproduce it, feel free to take a look as well.

@laichiaheng
Copy link

@Oschowa It really does much better than the default pulse audio output, no frame mistimed, no vsync jitter. Maybe it's time to pull request?

@t-8ch
Copy link
Author

t-8ch commented Nov 20, 2021

@Oschowa What would you think about sending a PR to mpv that keeps ao-pipewire out of the default selection?
That way the users that prefer it can use it and nobody is negatively affected without their knowledge.
Furthermore there would be a unified base on which others could improve on the code.

@etircopyh
Copy link

For some reason I have a much more lower volume on the same level of ao_pipewire counter to what I have with ao_pulse or even ao_openal with pipewire backend. It is reproducible with and without the PR.

@Oschowa
Copy link
Owner

Oschowa commented Dec 10, 2021

@laichiaheng @t-8ch sorry for the late response, but i have no really intention to open a PR for this because for me the vsync jitter is worse with this than with the ALSA ao on pipewire and it doesn't really improve anything. Although if anyone wants to do it instead feel free to use any of the code here.

@t-8ch
Copy link
Author

t-8ch commented Dec 10, 2021

@Oschowa Thanks for your response!
I opened mpv-player#9587
For me the AO works fine and has better metadata handling than the ALSA one and other users are reporting better performance than ALSA on their setups, so I think it makes sense to have this AO in mpv natively.

I'll move this PR forward, so their should be no work needed from you. Thanks for your work!

@t-8ch
Copy link
Author

t-8ch commented Sep 26, 2022

@Oschowa If you have the time would you test if you are still seeing the vsync jitter on the current ao_pipewire on mpv master?
If it is still reproducible could you also share same information about your system and how to reproduce the issue?
I think this would be one of the last known issues with the new ao.

@t-8ch
Copy link
Author

t-8ch commented Oct 6, 2022

PR is not relevant anymore, as ao_pipewire is now in mpv master.

@t-8ch t-8ch closed this Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants