-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
ao_pipewire fixes and media control #1
Conversation
FYI @Oschowa |
Looks good. FWIW, i've noticed that the current pipewire backend here has issues i haven't figured out yet. The most prominent one is that there is significantly more frame judder or repeated frames with the default |
@Oschowa It really does much better than the default pulse audio output, no frame mistimed, no vsync jitter. Maybe it's time to pull request? |
@Oschowa What would you think about sending a PR to mpv that keeps ao-pipewire out of the default selection? |
For some reason I have a much more lower volume on the same level of ao_pipewire counter to what I have with ao_pulse or even ao_openal with pipewire backend. It is reproducible with and without the PR. |
@laichiaheng @t-8ch sorry for the late response, but i have no really intention to open a PR for this because for me the vsync jitter is worse with this than with the ALSA ao on pipewire and it doesn't really improve anything. Although if anyone wants to do it instead feel free to use any of the code here. |
@Oschowa Thanks for your response! I'll move this PR forward, so their should be no work needed from you. Thanks for your work! |
@Oschowa If you have the time would you test if you are still seeing the vsync jitter on the current ao_pipewire on mpv master? |
PR is not relevant anymore, as ao_pipewire is now in mpv master. |
No description provided.