Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PostgreSQL #94

Merged
merged 1 commit into from
Mar 1, 2018
Merged

Conversation

brianfajardo
Copy link
Contributor

#43 Hey guys, I added support for PostgreSQL. Note this is only for PostgreSQL! And since it's been asked for, I'm going to be looking into adding support for PostGIS. 🤙

@philtrep
Copy link
Member

philtrep commented Mar 1, 2018

@brianfajardo Thanks for the PR!

One small thing missing, please document how to change the credentials for the Postgres service just like we have it for the MySQL service. https://github.com/Osedea/nodock#change-the-mysql-databaseuserpassword

@brianfajardo
Copy link
Contributor Author

brianfajardo commented Mar 1, 2018

@philtrep Readme has been updated to show users how they can change the credentials to their liking!

Copy link
Member

@philtrep philtrep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After line 34, add:

   - [Change PostgreSQL database/user/password](#PostgreSQL-Database-User)

README.md Outdated
@@ -290,6 +291,21 @@ You can specify a `PROJECT_PATH` to change the directory in which `npm` will per
- MYSQL_USER=default_user
- MYSQL_PASSWORD=secret
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a anchor tag here:

<a name="PostgreSQL-Database-User"></a>

@philtrep philtrep merged commit f851f5e into Osedea:master Mar 1, 2018
@philtrep
Copy link
Member

philtrep commented Mar 1, 2018

@brianfajardo Fantastic! Thanks a bunch

@philtrep philtrep mentioned this pull request Mar 1, 2018
migmar70 added a commit to migmar70/nodock that referenced this pull request Jul 22, 2022
* Add support for PostgreSQL (Osedea#94)

* Gave ownership of app directory to www-app user (Osedea#109)

Co-authored-by: Brian Fajardo <bmf5@hotmail.com>
Co-authored-by: Philippe Trépanier <philtrep@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants