Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Github annotation for rule TitleUnderlineLengthMustMatchTitleLength #1705

Merged
merged 2 commits into from Apr 4, 2024
Merged

Fix Github annotation for rule TitleUnderlineLengthMustMatchTitleLength #1705

merged 2 commits into from Apr 4, 2024

Conversation

alamirault
Copy link
Collaborator

Fix #1704

Github workflow command annotation seems to not support multi-line

It's our case here

Before fix
image

After fix

image

We should not use $lines->current()->raw() in violation message to avoid this error.

(Phpunit is maybe green because we de assertEquals on objects, not 100% sure)

@OskarStark OskarStark merged commit 9a743ba into OskarStark:develop Apr 4, 2024
6 of 8 checks passed
OskarStark added a commit that referenced this pull request Apr 4, 2024
@OskarStark
Merge branch 'develop'
9938746 
* develop:
  Fix Github annotation for rule TitleUnderlineLengthMustMatchTitleLength (#1705)
  composer(deps): bump symfony/config from 7.0.4 to 7.0.6 (#1700)
  composer(deps): bump symfony/dependency-injection from 7.0.4 to 7.0.6 (#1701)
  composer(deps): bump symfony/console from 7.0.4 to 7.0.6 (#1702)
@alamirault alamirault deleted the hotfix/1704-fix-github-annotation branch April 4, 2024 05:31
@MrYamous
Copy link
Collaborator

MrYamous commented Apr 4, 2024

I have found other rules that use $lines->current()->raw() in violation message. Do you think we should change them as a precaution ?

@OskarStark
Copy link
Owner

As long as it works, let's keep it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Message is broken
3 participants
@alamirault @MrYamous @OskarStark