Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php8 compatibility #842

Merged
merged 1 commit into from
Dec 21, 2020
Merged

php8 compatibility #842

merged 1 commit into from
Dec 21, 2020

Conversation

smoench
Copy link
Collaborator

@smoench smoench commented Nov 27, 2020

No description provided.

@OskarStark
Copy link
Owner

Thank you very much 🥰

@smoench
Copy link
Collaborator Author

smoench commented Nov 27, 2020

Unfortunately, we need to wait for stable 8.0 docker images.

@OskarStark
Copy link
Owner

Any significant performance increase using php 8?

@OskarStark
Copy link
Owner

Images are available, right?

@smoench
Copy link
Collaborator Author

smoench commented Dec 1, 2020

Sure, but not for x86-64 (only arm, ppc and s390) 🙈

@smoench
Copy link
Collaborator Author

smoench commented Dec 2, 2020

amd64 architecture is now available but box seems to have a problem. Might be related to box-project/box#489

 ---> 1d6fb4c0c879
Step 7/19 : ADD https://github.com/humbug/box/releases/download/3.10.0/box.phar ./box.phar
Downloading [==================================================>]   1.89MB/1.89MB
 ---> 30a4fd1945dc
Step 8/19 : RUN php box.phar compile
 ---> Running in f81d5263f939

Box Requirements Checker
========================

> Using PHP 8.0.0
> PHP is using the following php.ini file:
  WARNING: No configuration file (php.ini) used by PHP!

> Checking Box requirements:
  E.....


 [ERROR] Your system is not ready to run the application.


Fix the following mandatory requirements:
=========================================

 * The application requires the version "^7.3" or greater.

The command '/bin/sh -c php box.phar compile' returned a non-zero code: 1

Or box is not ready for PHP 8 but I'm already working on it humbug/php-scoper#446 (first php-scoper needs be php 8 compatible then box can be updated).

@OskarStark
Copy link
Owner

Any news on this @smoench ?

@smoench
Copy link
Collaborator Author

smoench commented Dec 14, 2020

Still in progress box-project/box#508

@OskarStark
Copy link
Owner

Looks like its passing, right?

@smoench
Copy link
Collaborator Author

smoench commented Dec 21, 2020

Yes, it passes now. Just had adjust the Dockerfile

@OskarStark OskarStark merged commit c34cdea into OskarStark:master Dec 21, 2020
@smoench smoench deleted the php8 branch December 21, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants