-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pre/post composer commands #67
Conversation
Er already have REQUIRE_DEV, can't we use this? |
But it's not meant for the same purpose |
I agree, will merge and release tomorrow |
On a second thought, what about adding an option for pre and post commands as array? So everyone can execute what he wants? Does this makes sense? |
You're right, it could be more flexible indeed. |
I changed my PR accordingly, but I'm not 100% confident if I did it the right way (sorry, I'm not very skilled in bash) |
Me neither 😄 Lets see if it works :-) |
I released 1.10 |
this breaks the build with a bash error about "bad substitution": i had to downgrade to 1.8.0 to get my build to work again. 1.9.0 seems not installable with docker, dunno why. |
Weird as this was released in 1.10 |
i was using latest, so it installed 1.10.0 which has this change and failed. |
@garak does it work for you if you provide your commands? |
note that i do not provide any commands. i guess it is supposed to work in that case too, but maybe something is wrong. not sure if maybe there is some name clash in github actions when one does not explicitly define the variables. |
Yes, that's why I wanted to know if it works with commands as expected, in this case we must provide a default when someone tries to run the action without commands |
Lets revert this for now |
This reverts commit 0bc2391.
Fix #66