for add-project-folder, use current path if non selected #149
Conversation
| @@ -592,7 +592,7 @@ describe('Functional tests', () => { | |||
|
|
|||
| it('can open files in new split panes', () => { | |||
| atom.workspace.open(fixturePath('sample.js')); | |||
| expect(atom.workspace.getPanes().length).toEqual(1); | |||
| const initialPaneCount = atom.workspace.getPanes().length; | |||
There was a problem hiding this comment.
this test was failing for me, and I found using a relative pane count fixed it.
There was a problem hiding this comment.
This looks great to me, thanks for the patch!
There's one minor bug that I don't actually understand; it seems that if I try to use the "add current directory" function to add a directory that is already a project directory, it doesn't beep. Instead, if shows the success notification again, although it doesn't duplicate the directory or anything.
But, as far as I can tell, it's addProjectFolder that should be checking this, not your code. Any ideas as to why this is happening?
|
It looks like the current atom does not beep if one attempts to re-add the directory: it just silently returns: https://github.com/atom/atom/blob/v1.21.0/src/project.coffee#L233 If you'd like, I'm happy to add a beep, or other behavior in this case. But it seems like the intended behavior is to be silent about it. |
|
Nah, this is probably fine then. It's minor anyway. This is out as v0.16.7 now. Thanks again! |
Hi! I'm coming to atom from emacs, and advanced-open-file rocks.
I'd love to save the down keystroke when I'm adding a project folder. This patch would allow using the currentPath, if it's a folder.