Skip to content

Commit

Permalink
Removed unnecessary duplicates of procedural files, updated procedura…
Browse files Browse the repository at this point in the history
…l-material to take colour parameters, reverted gladius-cubicvr libraries to versions that exist upstream on github
  • Loading branch information
David Perit committed Jun 5, 2012
1 parent f0d9fcd commit 57321d1
Show file tree
Hide file tree
Showing 9 changed files with 45 additions and 130 deletions.
26 changes: 21 additions & 5 deletions examples/assets/procedural-material.js
@@ -1,5 +1,21 @@
function proc( options ) {
return {
color: [1, 0.2, 0]
};
}
function proc( options ) {
options = options || {};
if (options.colorR === undefined){
options.colorR = 1;
}else{
options.colorR = parseInt(options.colorR);
}
if (options.colorG === undefined){
options.colorG = 0.2
}else{
options.colorG = parseInt(options.colorG);
}
if (options.colorB === undefined){
options.colorB = 0;
}else{
options.colorB = parseInt(options.colorB);
}
return {
color: [options.colorR, options.colorG, options.colorB]
};
}
8 changes: 4 additions & 4 deletions examples/cube-collision/cube-collision.js
Expand Up @@ -45,7 +45,7 @@ document.addEventListener( "DOMContentLoaded", function( e ) {
[
{
type: engine["gladius-cubicvr"].Mesh,
url: 'procedural-mesh.js',
url: '../assets/procedural-mesh.js',
load: engine.loaders.procedural,
onsuccess: function( mesh ) {
resources.mesh = mesh;
Expand All @@ -55,7 +55,7 @@ document.addEventListener( "DOMContentLoaded", function( e ) {
},
{
type: engine["gladius-cubicvr"].MaterialDefinition,
url: 'procedural-material.js',
url: '../assets/procedural-material.js',
load: engine.loaders.procedural,
onsuccess: function( material ) {
resources.material = material;
Expand All @@ -65,7 +65,7 @@ document.addEventListener( "DOMContentLoaded", function( e ) {
},
{
type: engine["gladius-cubicvr"].MaterialDefinition,
url: 'procedural-material.js?colorR=0&colorG=0&colorB=1',
url: '../assets/procedural-material.js?colorR=0&colorG=0&colorB=1',
load: engine.loaders.procedural,
onsuccess: function( material ) {
resources.materialBlue = material;
Expand All @@ -75,7 +75,7 @@ document.addEventListener( "DOMContentLoaded", function( e ) {
},
{
type: engine["gladius-cubicvr"].MaterialDefinition,
url: 'procedural-material.js?colorR=0&colorG=1&colorB=0',
url: '../assets/procedural-material.js?colorR=0&colorG=1&colorB=0',
load: engine.loaders.procedural,
onsuccess: function( material ) {
resources.materialGreen = material;
Expand Down
21 changes: 0 additions & 21 deletions examples/cube-collision/procedural-material.js

This file was deleted.

43 changes: 0 additions & 43 deletions examples/cube-collision/procedural-mesh.js

This file was deleted.

4 changes: 2 additions & 2 deletions examples/cube-impulse/cube-impulse.js
Expand Up @@ -45,7 +45,7 @@ document.addEventListener( "DOMContentLoaded", function( e ) {
[
{
type: engine["gladius-cubicvr"].Mesh,
url: 'procedural-mesh.js',
url: '../assets/procedural-mesh.js',
load: engine.loaders.procedural,
onsuccess: function( mesh ) {
resources.mesh = mesh;
Expand All @@ -55,7 +55,7 @@ document.addEventListener( "DOMContentLoaded", function( e ) {
},
{
type: engine["gladius-cubicvr"].MaterialDefinition,
url: 'procedural-material.js',
url: '../assets/procedural-material.js',
load: engine.loaders.procedural,
onsuccess: function( material ) {
resources.material = material;
Expand Down
5 changes: 0 additions & 5 deletions examples/cube-impulse/procedural-material.js

This file was deleted.

43 changes: 0 additions & 43 deletions examples/cube-impulse/procedural-mesh.js

This file was deleted.

23 changes: 17 additions & 6 deletions gladius-cubicvr.js
Expand Up @@ -23687,22 +23687,31 @@ define('src/components/model',['require','common/extend','base/component'],funct
var Model = function( service, mesh, materialDefinition ) {
Component.call( this, "Model", service, ["Transform"] );

this._cubicvrMesh = mesh || new service.target.context.Mesh();
setMaterialDefinition.call(this, materialDefinition || new service.target.context.Material());
this._cubicvrMesh = null;
this._cubicvrMaterialDefinition = null;

setMesh.call( this, mesh || new service.target.context.Mesh() );
setMaterialDefinition.call( this, materialDefinition || new service.target.context.Material() );
};
Model.prototype = new Component();
Model.prototype.constructor = Model;

function setMaterialDefinition(materialDefinition){
if (materialDefinition){
this._cubicvrMaterialDefinition = materialDefinition;
}
function setMaterialDefinition( materialDefinition ){
this._cubicvrMaterialDefinition = materialDefinition;
}

function getMaterialDefinition(){
return this._cubicvrMaterialDefinition;
}

function setMesh( mesh ) {
this._cubicvrMesh = mesh;
}

function getMesh() {
return this._cubicvrMesh;
}

function onUpdate( event ) {
}

Expand Down Expand Up @@ -23740,6 +23749,8 @@ define('src/components/model',['require','common/extend','base/component'],funct
var prototype = {
getMaterialDefinition: getMaterialDefinition,
setMaterialDefinition: setMaterialDefinition,
getMesh: getMesh,
setMesh: setMesh,
onUpdate: onUpdate,
onEntitySpaceChanged: onEntitySpaceChanged,
onComponentOwnerChanged: onComponentOwnerChanged,
Expand Down
2 changes: 1 addition & 1 deletion gladius-cubicvr.min.js

Large diffs are not rendered by default.

0 comments on commit 57321d1

Please sign in to comment.