Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection reset by peer when ssl context check_hostname is false and certificate verification is none #67

Conversation

oussamaessaji
Copy link
Member

Test case:

  • Disabling the hostname check and the certificate verification leads to Errno104:
    Screenshot from 2024-04-24 12-11-17
  • Enabling the hostname check and the certificate verification makes the ssl wrapped connection work:
    Untitled design

Conclusion:

The first case that doesn't work may be due to the server's SSL/TLS configuration or the requirements of the server.

@3asm
Copy link
Member

3asm commented Apr 24, 2024

As discussed, server_hostname is for SNI and is not related to context check_hostname.

@3asm 3asm merged commit 1d5a5f8 into main Apr 24, 2024
3 checks passed
@3asm 3asm deleted the fix/Connection_reset_by_peer_when_ssl_context_check_hostname_is_false branch April 24, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants