Added hostname segment and isGitDir #1
Conversation
baol
commented
Oct 27, 2016
•
baol
commented
- Implemented a simple hostname segment
- isGitDir will avoid spawning a process when not in a git dir
| @@ -21,7 +21,7 @@ import ( | |||
| "fmt" | |||
| "os" | |||
|
|
|||
| "github.com/otann/powerline-go/powerline" | |||
| "github.com/baol/powerline-go/powerline" | |||
There was a problem hiding this comment.
Well, I understand the purpose behind, but it doesn't makes sense in this fork ;)
| func HostSegment(t Theme) Segment { | ||
| hn, _ := os.Hostname() | ||
| return Segment{ | ||
| Bg: t.Lock.Bg, |
There was a problem hiding this comment.
Should there be additional config for home segment colors as well?
| @@ -124,7 +146,11 @@ func getGitInformation() (string, bool) { | |||
| return status, staged | |||
| } | |||
|
|
|||
| func GitSegment(t Theme) Segment { | |||
| func GitSegment(cwdParts []string, t Theme) Segment { | |||
| if !isGitDir(cwdParts) { | |||
There was a problem hiding this comment.
I think this should be done in getGitInformation, also isn't there a way to check same thing without constructing a path from it's parts?
There was a problem hiding this comment.
Maybe, maybe not. getGitInformation at the moment gets information from git, isGitDir is a pre-filter. cwdParts was the closest information to what was needed that is already available to other segments.
|
Thanks a lot for this segment! This will be of much use, when reading configuration from file will be added |
|
How would you handle reading from config without reading the config every time? Env variables maybe? |
|
I think both, readingsimple json from file should be really quick |
