Nullable type for tasks that return null

pkg/task/nullable.go

@@ -0,0 +1,3 @@
+package task
+
+type Nullable struct{}

pkg/task/s3/s3_uploader.go

@@ -8,10 +8,11 @@ import (
 	"github.com/aws/aws-sdk-go/aws"
 	"github.com/aws/aws-sdk-go/service/s3"
 	"github.com/aws/aws-sdk-go/service/s3/s3iface"
+	"github.com/otaviohenrique/vecna/pkg/task"
 )
 
 // S3Uploader is a task which will upload a given data on the given path (key) of one bucket
-type S3Uploader[I *S3UploaderInput, O []byte] struct {
+type S3Uploader[I *S3UploaderInput, O task.Nullable] struct {
 	// S3 AWS client to be used
 	client s3iface.S3API
 	// Bucket name where all objects will be stored
@@ -28,7 +29,7 @@ type S3UploaderInput struct {
 	Content []byte
 }
 
-func NewS3Uploader[I *S3UploaderInput, O []byte](client s3iface.S3API, bucketName string, logger *slog.Logger) *S3Uploader[I, O] {
+func NewS3Uploader[I *S3UploaderInput, O task.Nullable](client s3iface.S3API, bucketName string, logger *slog.Logger) *S3Uploader[I, O] {
 	u := new(S3Uploader[I, O])
 
 	u.client = client
@@ -43,7 +44,7 @@ func NewS3Uploader[I *S3UploaderInput, O []byte](client s3iface.S3API, bucketNam
 func (s *S3Uploader[I, O]) Run(_ context.Context, input I, meta map[string]interface{}, _ string) (O, error) {
 	err := s.uploadObject(input)
 
-	return nil, err
+	return O(task.Nullable{}), err
 }
 
 func (s *S3Uploader[T, K]) uploadObject(input *S3UploaderInput) error {

pkg/task/sqs/sqs_deleter.go

@@ -8,6 +8,7 @@ import (
 	"github.com/aws/aws-sdk-go/aws"
 	"github.com/aws/aws-sdk-go/service/sqs"
 	"github.com/aws/aws-sdk-go/service/sqs/sqsiface"
+	"github.com/otaviohenrique/vecna/pkg/task"
 )
 
 type SQSDeleterOpts struct {
@@ -16,15 +17,15 @@ type SQSDeleterOpts struct {
 }
 
 // SQSDeleter will delete a message on SQS based on a given receiptHandle
-type SQSDeleter[I string, O []byte] struct {
+type SQSDeleter[I string, O task.Nullable] struct {
 	// SQS AWS Client to be used
 	client   sqsiface.SQSAPI
 	logger   *slog.Logger
 	opts     *SQSDeleterOpts
 	queueURL *string
 }
 
-func NewSQSDeleter[I string, O []byte](client sqsiface.SQSAPI, logger *slog.Logger, opts *SQSDeleterOpts) *SQSDeleter[I, O] {
+func NewSQSDeleter[I string, O task.Nullable](client sqsiface.SQSAPI, logger *slog.Logger, opts *SQSDeleterOpts) *SQSDeleter[I, O] {
 	c := new(SQSDeleter[I, O])
 
 	c.client = client
@@ -54,12 +55,12 @@ func (s *SQSDeleter[I, O]) Run(_ context.Context, input I, meta map[string]inter
 	_, err := s.deleteMessage(string(input))
 
 	if err != nil {
-		return nil, err
+		return O(task.Nullable{}), err
 	}
 
 	s.logger.Debug("sqs message deleted", "receiptHandle", string(input))
 
-	return nil, nil
+	return O(task.Nullable{}), nil
 }
 
 func (s *SQSDeleter[I, O]) deleteMessage(receipt string) (*sqs.DeleteMessageOutput, error) {

pkg/task/sqs/sqs_deleter_test.go

@@ -10,6 +10,7 @@ import (
 	"github.com/aws/aws-sdk-go/aws"
 	awsSqs "github.com/aws/aws-sdk-go/service/sqs"
 	"github.com/aws/aws-sdk-go/service/sqs/sqsiface"
+	"github.com/otaviohenrique/vecna/pkg/task"
 	"github.com/otaviohenrique/vecna/pkg/task/sqs"
 )
 
@@ -97,7 +98,7 @@ func TestSQSDeleter_Run(t *testing.T) {
 				t.Errorf("SQSDeleter.Run() error = %v, wantErr %v", err, tt.wantErr)
 				return
 			}
-			if !tt.wantErr && got != nil {
+			if !tt.wantErr && (got != task.Nullable{}) {
 				t.Errorf("SQSDeleter.Run() = %v, want %v", got, nil)
 			}
 		})

pkg/task/sqs/sqs_producer.go

@@ -8,6 +8,7 @@ import (
 	"github.com/aws/aws-sdk-go/aws"
 	"github.com/aws/aws-sdk-go/service/sqs"
 	"github.com/aws/aws-sdk-go/service/sqs/sqsiface"
+	"github.com/otaviohenrique/vecna/pkg/task"
 )
 
 // SQS Producer  options
@@ -24,15 +25,15 @@ type SQSProducerInput struct {
 }
 
 // Simple generic task to produce messages to SQS
-type SQSProducer[I SQSProducerInput, O []byte] struct { //TODO nullable type
+type SQSProducer[I SQSProducerInput, O task.Nullable] struct { //TODO nullable type
 	// SQS AWS client to be used
 	client   sqsiface.SQSAPI
 	logger   *slog.Logger
 	opts     *SQSProducerOpts
 	queueURL *string
 }
 
-func NewSQSProducer[I SQSProducerInput, O []byte](client sqsiface.SQSAPI, logger *slog.Logger, opts *SQSProducerOpts) *SQSProducer[I, O] {
+func NewSQSProducer[I SQSProducerInput, O task.Nullable](client sqsiface.SQSAPI, logger *slog.Logger, opts *SQSProducerOpts) *SQSProducer[I, O] {
 	p := new(SQSProducer[I, O])
 
 	p.client = client
@@ -68,5 +69,5 @@ func (c *SQSProducer[I, O]) Run(_ context.Context, i I, meta map[string]interfac
 		QueueUrl:          c.queueURL,
 	})
 
-	return nil, err
+	return O(task.Nullable{}), err
 }