Add documentation, slighly reorganize collector code #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Others
force-pushed
the
document_collector
branch
from
5325a15
to
6a9e549
Compare
seanchen1991
previously approved these changes
Jun 14, 2020
src/collector/mod.rs
Outdated
| @@ -422,6 +453,7 @@ impl Collector { | |||
| // Now cleanup by removing all the data that is done for | |||
| par_retain(&self.tracked_data.data, |data, _| { | |||
| // Mark the new data as in use for now | |||
| // This stops us blinding data that was allocated during collection | |||
There was a problem hiding this comment.
I think you meant “building” instead of “blinding” here? Not 100% sure, but it seems like a typo.
src/collector/mod.rs
Outdated
| @@ -386,6 +415,8 @@ impl Collector { | |||
|
|
|||
| // eprintln!("roots {:?}", roots); | |||
|
|
|||
| // This step is dfs through the object graph (strating with the roots) | |||
There was a problem hiding this comment.
This is what I get for writing comments while tired... Will push fix tomorrow
Should make the collector a little easier to follow
Others
force-pushed
the
document_collector
branch
from
6a9e549
to
8a2003e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should make the collector a little easier to follow.
Resolves #30 for now
@seanchen1991 can you take a look at this?