Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on Ubuntu 20.04 #39

Closed
shubhexists opened this issue Dec 1, 2023 · 8 comments · Fixed by #41
Closed

Not working on Ubuntu 20.04 #39

shubhexists opened this issue Dec 1, 2023 · 8 comments · Fixed by #41

Comments

@shubhexists
Copy link
Contributor

I tried running this on Ubuntu 20.04, it is getting the commands right in the terminal, but it is not actually navigating to the desired location. For example, I asked it to open brave and navigate to this repository... It is getting the steps right, but it could not open Brave....

Possible Issue

  • I think the method to search apps is different in MacOS ( I haven't used Mac, so I am not aware though) and in my system....
    Hence, it might mot be able to go to the apps menu to actually search for any software.. Maybe?
@michaelhhogue
Copy link
Collaborator

@shubhexists This is a known issue. For now, the search command is tailored for Mac OS. Restricting your prompt to reference UI elements which are already on-screen is a work-around. Having a set way to open a launcher/menu via key shortcuts is going to be more difficult in Linux as there isn't one set way to open the launcher/menu like in Mac OS.

One possible way to resolve this issue on GNU/Linux could be to simply prompt the user for their keyboard shortcut to open a launcher/menu/search.

@stefangrotz
Copy link

stefangrotz commented Dec 1, 2023

Windows Key + type should work in most Linux distros (+ in Windows). I will test it later and maybe also create a PR with a fix for Ubuntu.

@shubhexists
Copy link
Contributor Author

I guess I agree that windows key + type might be an option that may cover a much wider range of devices

@shubhexists
Copy link
Contributor Author

shubhexists commented Dec 1, 2023

Should I try adding Linux here

if platform.system() == "Windows":

and see what the result is ?
Edit - Because I dont think Key down is as common as windows key...

@michaelhhogue
Copy link
Collaborator

@shubhexists Yeah this is a good default. It personally isn't the key I use to open the menu (I have a keyboard intended for Macs, so I have command/alt open the menu), so I'm probably biased against it. But you are right, this is certainly most common for Linux.

@shubhexists
Copy link
Contributor Author

shubhexists commented Dec 1, 2023

Hi I solved it and now it is searching applications using the windows key...
If you agree, I can make a PR adding this to the main repository?
Edit - It seems brave has a diff position for search bar than chrome : ) That required manual intermission

Demo

Screencast.2023-12-01.20.58.07.mp4

@michaelhhogue
Copy link
Collaborator

michaelhhogue commented Dec 1, 2023

@shubhexists That looks great! This should be a good PR.

shubhexists added a commit to shubhexists/self-operating-computer that referenced this issue Dec 1, 2023
@joshbickett
Copy link
Contributor

Merged the PR. Thanks for monitoring @michaelhhogue and adding the code @shubhexists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants