Add support for LLaVA through Ollama #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just did initial pass. I can see it working, but see what you mention about higher error rates. Not a problem though, this is great progress. I need to get back to some other tasks, but I'll take a final look later and merge it in. @michaelhhogue |
|
@michaelhhogue merged, great job! I'm going to play around with improving the prompts and see if I can get LLaVa to perform better. Either way I'll do a Twitter post about it this week or next and mention you, thanks again! |
This was referenced Feb 9, 2024
|
@joshbickett Sounds good. Let me know if you notice anything that can be improved with the llava support. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR uses the new Ollama Python module to add support for locally hosted vision models.
llavawill be the first supported local model through Ollama.Instructions were also added to the README for how to get up and running with LLaVA through Ollama.
Type of change
Important
Accuracy when using LLaVA is extremely low. However, this PR serves as a starting point for developers to build off of as local vision models improve.