Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: moved main to main.py and added some type annotations #154

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mjspeck
Copy link

@mjspeck mjspeck commented Feb 7, 2024

What does this PR do?

Just moved the main function to main.py and added some type annotations. I plan to add a lot more to make developing easier. I can move main back to operate.py if necessary, but it feels very disorganized to have it anywhere other than main.py.

Requirement/Documentation

No docs required.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tests (Unit/Integration/E2E or any other test)
  • This change requires a documentation update

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected. Make sure before submitting this PR you run tests with evaluate.py

@mjspeck mjspeck mentioned this pull request Feb 7, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant