Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added German translation #78

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Added German translation #78

merged 2 commits into from
Apr 11, 2019

Conversation

simonwep
Copy link
Contributor

#67 Used the Zeta Resource Editor, hope it didn't messed up the format (got some errors because of apparently invisible characters lol). Used as base branch your develop one, hope that's correct.

@Otiel
Copy link
Owner

Otiel commented Apr 11, 2019

Thanks!

I'll fix the format to line it up with the other resx files, no problem. 👌

However, can you push on a new branch instead of develop please?

@simonwep
Copy link
Contributor Author

Sounds good :) Yeah you wrote it in your description, I've made a translation-german branch. To push things I only could choose on of these:

image

Or I'm missing something? :suspect:

@Otiel
Copy link
Owner

Otiel commented Apr 11, 2019

Well ok, I didn't know GitHub doesn't allow to create a new branch for a pull request. My bad. On develop it's fine then. 👌

<value>_Maximale Dwnloadversuche</value>
</data>
<data name="labelDownloadRetryCooldown" xml:space="preserve">
<value>Wiederholungs Q_artezeit</value>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean "Wartezeit" like on the tooltip (l.408 and 417)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes!

<value>_Artist</value>
</data>
<data name="labelButtonResetSettings" xml:space="preserve">
<value>Einstellungen _Zurücksetzen</value>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would "_Zurücksetzen" be enough for the context? That would allow me not to enlarge the button width:

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, absolutely.

@Otiel Otiel changed the base branch from develop to translation-german April 11, 2019 14:14
@Otiel
Copy link
Owner

Otiel commented Apr 11, 2019

Ah! We can edit a PR to change the base branch afterwards. I've created translation-german on this repo and edited the PR. 😃

@Otiel Otiel self-assigned this Apr 11, 2019
@Otiel Otiel added this to the Next version milestone Apr 11, 2019
@simonwep
Copy link
Contributor Author

Updated the translations ~ fixed one or two small grammar mistakes. Must be really tired as I wrote these haha

Copy link
Owner

@Otiel Otiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the corrections. Looks good. 👍

@Otiel Otiel merged commit 7243374 into Otiel:translation-german Apr 11, 2019
@Otiel
Copy link
Owner

Otiel commented Apr 11, 2019

Thanks again for the translation, I will add it to the next release. ❤️

@Otiel
Copy link
Owner

Otiel commented Apr 17, 2019

The german translation has been added in v0.2.7.0.

@Otiel Otiel removed this from the Next version milestone Apr 23, 2019
@Otiel Otiel removed their assignment Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants