Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks manager: Visits counter not incremented properly #1542

Open
beastie1 opened this issue Sep 13, 2018 · 5 comments
Open

Bookmarks manager: Visits counter not incremented properly #1542

beastie1 opened this issue Sep 13, 2018 · 5 comments

Comments

@beastie1
Copy link
Contributor

The Visits counter in a bookmark's Properties is not incremented properly. It seems that every time a bookmark is loaded, the counter is increased by 3 instead of 1.

@aurhat
Copy link
Contributor

aurhat commented Sep 14, 2018

It works correct in my RC 12/current master branch, maybe it happens only on some specific websites? Could you give an example of such website?

@beastie1
Copy link
Contributor Author

Thanks @aurhat and sorry for the belated reply. It seems to occur randomly: many bookmarks have that problems while others don't. Maybe it's related to how old these are (when they were added) or it has something to do with the bookmark file itself. The file (and profile) is quite old so I'm not sure all the automatic migrations went through properly.
I'll have to do further testing with the bookmark file and profile when I have some free time.

@beastie1
Copy link
Contributor Author

beastie1 commented Oct 2, 2018

Another issue that may be related is that the Visits are not incremented when there's any kind of redirection.

Say for example the bookmark was initially saved with the http protocol but the server now redirects to https (http://domain.com vs https://domain.com) or it was saved with (or without) the www subdomain (domain.com vs www.domain.com).

The only way to solve this is by editing the bookmarks to reflect the changes.

@beastie1
Copy link
Contributor Author

beastie1 commented Oct 3, 2018

So I finally got the time to test this out. The first issue is caused by History/RememberBrowsing=false.

Can you reproduce the bug on your setup?

@aurhat
Copy link
Contributor

aurhat commented Oct 3, 2018

Yes, nice 👍

Emdek added a commit that referenced this issue Oct 3, 2018
Emdek added a commit that referenced this issue Jan 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants