Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tray icon #18

Closed
CucumisSativus opened this issue Jan 2, 2014 · 7 comments
Closed

Tray icon #18

CucumisSativus opened this issue Jan 2, 2014 · 7 comments

Comments

@CucumisSativus
Copy link

I would like to add a tray icon to your application (one of the easiest jobs i found). Could You give me a hint in which file should I put the code?

Ps. You mentioned IRC contact in one of already closed issues, could You give some info about channel? Would be nice if it will be visible in readme

@Emdek
Copy link
Member

Emdek commented Jan 2, 2014

It is listed on homepage, #otter-browser on freenode.
OK, it should be added into ui/ directory, class should be named Otter::TrayIcon and code has to follow this style:
http://en.wikipedia.org/wiki/Indent_style#Allman_style
Using tabs and following naming scheme.
Be warned that I'm very strict about those conventions. ;-)
Menu layout may follow that of Opera but for now it should have only first three actions (using ActionsManager for adding tab), other ones should be added by modules (that can wait until proper API will be ready).
If you want you can also add option to hide it (preferably default to hide) in options.ini (preferred name: Browser/ShowTrayIcon), I'm against adding command line toggle for it, for me that was wrong route to allow to disable it, taken by Opera.

@CucumisSativus
Copy link
Author

Just to avoid possible duplication. I would like to be responsible for this part, thanks in advance.

@lollox
Copy link

lollox commented Sep 10, 2014

not sure if I miss something, but on my system (Win7 x64) I've no tray icon with the latest build and I don't see any option for it

@beastie1
Copy link
Contributor

I was about to open a new ticket but since @lollox already posted this here, I will just confirm that Weekly 36 doesn't show any tray icon (tested on Windows 7, too).
I tried to disable then reenable it, but it didn't change anything.

@Katarn
Copy link
Contributor

Katarn commented Sep 10, 2014

Qt5 itself has a problem with system tray, confirmed on Qt bugtracker, at least in Xfce. Qt4 applications works perfectly. Maybe under Windows can also have this bug?

Emdek added a commit that referenced this issue Sep 10, 2014
@Emdek
Copy link
Member

Emdek commented Sep 10, 2014

Nope, it was simply extra character in option name. :-/

@Katarn
Copy link
Contributor

Katarn commented Dec 14, 2014

In Qt 5.4 solved the problem with displaying an icon in the system tray of the Xfce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants