Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getting_started_command_line.rst #102

Merged
merged 1 commit into from
Jan 6, 2019

Conversation

doskoi
Copy link
Contributor

@doskoi doskoi commented Dec 11, 2018

Use ${PWD} to set current directory are works on both Powershell and Linux

Description:

Related issue (if applicable): fixes

Pull request in esphomeyaml with YAML changes (if applicable): OttoWinter/esphomeyaml#
Pull request in esphomelib with C++ framework changes (if applicable): OttoWinter/esphomelib#

Checklist:

  • The documentation change has been tested and compiles correctly.
  • Branch: next is for changes and new documentation that will go public with the next esphomelib release. Fixes, changes and adjustments for the current release should be created against current.
  • Check this box if you have read, understand, comply, and agree with the Code of Conduct.

Use ${PWD} to set current directory are works on both Powershell and Linux
Copy link
Member

@OttoWinter OttoWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Two things:

  • Please accept the Code of Conduct by clicking the checkbox in the PR description.
  • I think it would be best if the quotes around the PWD would be kept. Otherwise this will fail for anybody in folders with spaces (I think).

@OttoWinter OttoWinter merged commit a01e05d into esphome:current Jan 6, 2019
@esphome esphome locked and limited conversation to collaborators Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants