New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getting_started_command_line.rst #102

Merged
merged 1 commit into from Jan 6, 2019

Conversation

Projects
None yet
2 participants
@doskoi
Copy link
Contributor

doskoi commented Dec 11, 2018

Use ${PWD} to set current directory are works on both Powershell and Linux

Description:

Related issue (if applicable): fixes

Pull request in esphomeyaml with YAML changes (if applicable): OttoWinter/esphomeyaml#
Pull request in esphomelib with C++ framework changes (if applicable): OttoWinter/esphomelib#

Checklist:

  • The documentation change has been tested and compiles correctly.
  • Branch: next is for changes and new documentation that will go public with the next esphomelib release. Fixes, changes and adjustments for the current release should be created against current.
  • Check this box if you have read, understand, comply, and agree with the Code of Conduct.
Update getting_started_command_line.rst
Use ${PWD} to set current directory are works on both Powershell and Linux
@OttoWinter
Copy link
Owner

OttoWinter left a comment

LGTM.

Two things:

  • Please accept the Code of Conduct by clicking the checkbox in the PR description.
  • I think it would be best if the quotes around the PWD would be kept. Otherwise this will fail for anybody in folders with spaces (I think).

@OttoWinter OttoWinter merged commit a01e05d into OttoWinter:current Jan 6, 2019

Mynasru added a commit to Mynasru/esphomedocs that referenced this pull request Jan 13, 2019

update fork from base (#1)
* Implement custom sensor platform

* Update

* HassIO -> Hass.io

* More custom component guides

* Generic custom component

* Updates

* CSE7766 Update Interval (OttoWinter#91)

* Update docs

* Fixes

* Fix

* Fix

* Fix

* Documentation for MAX31855 sensor (OttoWinter#97)

* MAX 31855 documentation

* Fix link

* Update image

* Fixed typo in Sonoff R2 Cover example (OttoWinter#112)

* Privacy Policy

* Upgrade footer

* Remove line

* Fix copy/paste error in turn_off_action (OttoWinter#113)

* Redirects

* Update docs

* total_daily_energy doesn't have pin option (OttoWinter#114)

* Getting started HassIO - USD device discovery (OttoWinter#110)

I had a bad cable, although it works for charging devices, it didn't work for discovering a wemos D1 on HassIO with RPI3

* Mismatch in example and text (OttoWinter#109)

The example uses Dehumidifier the text said relay

* BME280 environment cookbook entry (OttoWinter#107)

* bme280 environment cookbook entery

new cookbook entery fixing this issue:  OttoWinter#89

* Formatting

* Fixed formatting, removed global variables

Fixed formatting, removed global variables as requested by OttoWinter

* Comply with google C++ style guide

* Fixed brackets

* Tested and fixed typos/formatting

Yalm expamples were tested by Mihalski

* Update getting_started_command_line.rst (OttoWinter#102)

Use ${PWD} to set current directory are works on both Powershell and Linux

* Updated the multi click example code block (OttoWinter#92)

I had no luck triggering the "Single Long Clicked" with the timing of
- OFF for 1s to 2s
- ON for 1s to 2s
- OFF for at least 0.5s
I removed the waiting first time of OFF for, and now i can trigger it as expected.

* Add step to setting up devices (OttoWinter#101)

* Add step to setting up devices

Added activation of the MiFlora sensor with the native app.

* Formatting

* Fix

* Update bme280_environment.rst

* Bump version to v1.10.0b1

* Fix CNAME

* Update changelog

* Fix CNAME

* Add interval docs

* Add changelog breaking/notable changes+imgtable

* Bump version to v1.10.0b2

* Update

* Update v1.10.0.rst

* Update v1.10.0.rst

* Bump version to v1.10.0

* Fix substitutions example & api intro text (OttoWinter#117)

* Fix substitutions example

* Remove wrong intro text

* Fix spelling

* Fixed missing link to BME cookbook (OttoWinter#120)

Fixed missing link to BME cookbook

* Update index.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment