Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Wats 1.0.1 #26

Closed
24 of 27 tasks
wibeasley opened this issue Mar 7, 2023 · 1 comment
Closed
24 of 27 tasks

Release Wats 1.0.1 #26

wibeasley opened this issue Mar 7, 2023 · 1 comment
Assignees

Comments

@wibeasley
Copy link
Member

wibeasley commented Mar 7, 2023

First release:

Prepare for release:

  • git pull
  • Check if any deprecation processes should be advanced, as described in Gradual deprecation
  • urlchecker::url_check()
  • devtools::check(remote = TRUE, manual = TRUE)
  • devtools::check_win_devel()
  • rhub::check_for_cran()
  • git push
  • Draft blog post

Submit to CRAN:

  • usethis::use_version('major')
  • devtools::submit_cran()
  • Approve email

Wait for CRAN...

  • Accepted 🎉
  • git push
  • usethis::use_github_release()
  • usethis::use_dev_version()
  • usethis::use_news_md()
  • git push
  • Finish blog post
  • Tweet
  • Add link to blog post in pkgdown news menu
wibeasley added a commit that referenced this issue Mar 8, 2023
wibeasley added a commit that referenced this issue Mar 8, 2023
wibeasley added a commit that referenced this issue Mar 8, 2023
wibeasley added a commit that referenced this issue Mar 8, 2023
wibeasley added a commit that referenced this issue Mar 8, 2023
wibeasley added a commit that referenced this issue Mar 8, 2023
@wibeasley wibeasley self-assigned this Mar 8, 2023
@wibeasley
Copy link
Member Author

wibeasley commented Mar 10, 2023

Response from CRAN (I've added the checkboxes). I guess these things changed since the package was accepted in 2014.


  • If there are references describing the methods in your package, please
    add these in the description field of your DESCRIPTION file in the form
    authors (year) doi:...
    authors (year) arXiv:...
    authors (year, ISBN:...)
    or if those are not available: <[https:...]https:...>
    with no space after 'doi:', 'arXiv:', 'https:' and angle brackets for
    auto-linking.
    (If you want to add a title as well please put it in quotes: "Title")

  • The Description field is intended to be a (one paragraph) description of
    what the package does and why it may be useful. Please add more details
    about the package functionality and implemented methods in your
    Description text.

  • \dontrun{} should only be used if the example really cannot be executed
    (e.g. because of missing additional software, missing API keys, ...) by
    the user. That's why wrapping examples in \dontrun{} adds the comment
    ("# Not run:") as a warning for the user.
    Does not seem necessary.
    Please unwrap the examples if they are executable in < 5 sec, or replace
    \dontrun{} with \donttest{}.

  • Please always make sure to reset to user's options(), working directory
    or par() after you changed it in examples and vignettes and demos. ->
    inst/doc/mbr-figures.R
    e.g.:
    old <- options(digits = 3)
    ...
    options(old)

  • Please do not install packages in your functions, examples or vignette.
    This can make the functions,examples and cran-check very slow. e.g.:
    man/Wats-package.Rd

Please fix and resubmit.

Best,
Victoria Wimmer

wibeasley added a commit that referenced this issue Mar 10, 2023
wibeasley added a commit that referenced this issue Mar 10, 2023
wibeasley added a commit that referenced this issue Mar 10, 2023
requested by CRAN --even though it was in `\dontrun{}`
ref #26
wibeasley added a commit that referenced this issue Mar 10, 2023
wibeasley added a commit that referenced this issue Mar 10, 2023
requested by CRAN
ref #26
wibeasley added a commit that referenced this issue Mar 10, 2023
wibeasley added a commit that referenced this issue Mar 10, 2023
@wibeasley wibeasley changed the title Release Wats 1.0.0 Release Wats 1.0.1 Mar 10, 2023
wibeasley added a commit that referenced this issue Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant