Cypress E2E #1507
Merged
Cypress E2E #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -240,7 +240,9 @@ | |||
| SITE_ID = 1 | |||
| ACCOUNT_AUTHENTICATION_METHOD = "email" | |||
| ACCOUNT_EMAIL_REQUIRED = True | |||
| ACCOUNT_EMAIL_VERIFICATION = "mandatory" | |||
| ACCOUNT_EMAIL_VERIFICATION = str( | |||
| config("ACCOUNT_EMAIL_VERIFICATION", default="mandatory") | |||
There was a problem hiding this comment.
I'm not making use of this for this PR, and I thought I'd just remove it, but decided this would be handy for later.
| cy.get('button[type="submit"]').should('be.disabled'); | ||
| }); | ||
|
|
||
| it('Attempts to create an account', () => { |
There was a problem hiding this comment.
This actually creates a test account. It seems important to test, but without having a way to automatically delete these (say, via a script run under make or something similar), I've got mixed feelings about leaving this in.
pflopez
approved these changes
May 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds a basic framework for initial Cypress E2E tests.
Despite a bit of experimentation, the resulting PR isn't much different than the original Cypress PR.
I pulled in a few map tests from that, as well.
It seems like we have some decisions to make for when exactly we run this, but I left a manual workflow action in here for the moment. If we want to duplicate this and have it triggered elsewhere, that's easy enough to change.
Note: there are also some github repo secrets to set before we consider merging this.