Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input-field component #1513

Merged
merged 8 commits into from
May 17, 2024
Merged

Input-field component #1513

merged 8 commits into from
May 17, 2024

Conversation

pflopez
Copy link
Contributor

@pflopez pflopez commented May 14, 2024

Added input-field component, stories on storybook and a story to demo usage on a form

Screen Shot 2024-05-15 at 11 27 46 Screen Shot 2024-05-15 at 12 04 28

@pflopez pflopez changed the title Input component Input-field component May 15, 2024
@pflopez pflopez marked this pull request as ready for review May 15, 2024 15:05
* // use with reactive forms
* <sg-input-field>
* <input sgInput formControlName="...">
* </sg-input-field>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks for both examples

*/
@Input() supportMessage = '';

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: should we clarify which icon library is currently valid for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point!

Copy link
Contributor

@lastminutediorama lastminutediorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice, thanks for adding all of the options.

@pflopez pflopez merged commit 01a9c8a into main May 17, 2024
6 checks passed
@pflopez pflopez deleted the input-component branch May 17, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants