Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 config: Refactor Twitter & Telegram Actions #108

Merged
merged 7 commits into from
Jul 8, 2023

Conversation

KartikSoneji
Copy link
Member

@KartikSoneji KartikSoneji commented Oct 29, 2022

Adds a custom js script to directly call the telegram api and send/pin messages.
Fixes issues with the markdown formatting.
Combines 4 github workflows into one.

@KartikSoneji KartikSoneji requested a review from a team October 29, 2022 12:47
@KartikSoneji KartikSoneji self-assigned this Oct 29, 2022
.github/workflows/send-messages.yaml Outdated Show resolved Hide resolved
.github/workflows/send-messages.yaml Outdated Show resolved Hide resolved
util/post-telegram-message.js Show resolved Hide resolved
@KartikSoneji KartikSoneji force-pushed the feat-better-message-automation branch 2 times, most recently from b6f5446 to 4bc4d31 Compare November 6, 2022 00:53
@SirusCodes
Copy link
Member

@KartikSoneji is this ready for review?

@KartikSoneji
Copy link
Member Author

@KartikSoneji is this ready for review?

Yes, unless we are planning to shift to WhatsApp Communities.

@KartikSoneji KartikSoneji marked this pull request as ready for review November 16, 2022 14:48
@SirusCodes
Copy link
Member

Yes, unless we are planning to shift to WhatsApp Communities.

We haven't finalized anything like that but until then I guess we can merge it.

@KartikSoneji
Copy link
Member Author

Yes, unless we are planning to shift to WhatsApp Communities.

We haven't finalized anything like that but until then I guess we can merge it.

OK, I still have to add the wait action and push back the starting times.

@SirusCodes
Copy link
Member

@KartikSoneji still working on it?

@KartikSoneji KartikSoneji requested review from SirusCodes and a team and removed request for SirusCodes January 10, 2023 18:35
@HarshKapadia2
Copy link
Member

Hey @KartikSoneji I just remembered that there have been lots of cases (two in just the past two weeks) where the summary was delayed or there was some other issue, which made us have to run specific message workflows again. If we combine all message workflows in one workflow, we will lose the granular control that we currently enjoy. How do you think we should tackle this?

@KartikSoneji
Copy link
Member Author

@HarshKapadia2 I think this should still allow the same flexibility.

workflow_dispatch:
inputs:
message-template:
type: choice
required: true
default: automatic
options:
- automatic
- reminder
- joining
description: |
Which message template to use.
if set to `automatic`, resolves to:
`joining`, if time is after 10pm on Saturday (IST)
`reminder`, otherwise

.github/workflows/send-messages.yaml Outdated Show resolved Hide resolved
util/get-current-message-template.js Show resolved Hide resolved
.github/workflows/send-messages.yaml Outdated Show resolved Hide resolved
util/post-telegram-message.js Outdated Show resolved Hide resolved
util/post-telegram-message.js Outdated Show resolved Hide resolved
util/post-telegram-message.js Show resolved Hide resolved
util/post-telegram-message.js Show resolved Hide resolved
.github/workflows/send-messages.yaml Show resolved Hide resolved
.github/workflows/send-messages.yaml Show resolved Hide resolved
@HarshKapadia2
Copy link
Member

HarshKapadia2 commented Jan 15, 2023

@KartikSoneji this looks good to me and thank you SO much for this amazing Pull Request, but please just give this a cursory glance and then merge it if everything seems okay to you.

This makes me think, is there is way to check such CI/CD workflow changes before merging? Is building a separate testing environment the only answer?

@tusharnankani
Copy link
Member

Nudging @KartikSoneji 🥰

@HarshKapadia2
Copy link
Member

HarshKapadia2 commented Feb 16, 2023

With upcoming changes to the Twitter API, what should we do?

Should we move this conversation to a an issue or a discussion?

@tusharnankani
Copy link
Member

Let's move to an issue.

@SirusCodes
Copy link
Member

@KartikSoneji any updates?

@HarshKapadia2
Copy link
Member

This looks good to me. I'm going to merge it. Thank you so much, @KartikSoneji!

@HarshKapadia2 HarshKapadia2 changed the title feat: Refactor Twitter/Telegram actions 🔧 config: Refactor Twitter & Telegram Actions Jul 8, 2023
@HarshKapadia2 HarshKapadia2 merged commit 0d54459 into main Jul 8, 2023
@HarshKapadia2 HarshKapadia2 deleted the feat-better-message-automation branch July 8, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge telegram and twitter actions Use containers for actions Telegram messages
4 participants