-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 config: Refactor Twitter & Telegram Actions #108
Conversation
e577eb2
to
7b30efc
Compare
b6f5446
to
4bc4d31
Compare
@KartikSoneji is this ready for review? |
Yes, unless we are planning to shift to WhatsApp Communities. |
We haven't finalized anything like that but until then I guess we can merge it. |
OK, I still have to add the wait action and push back the starting times. |
@KartikSoneji still working on it? |
4bc4d31
to
06d0170
Compare
Hey @KartikSoneji I just remembered that there have been lots of cases (two in just the past two weeks) where the summary was delayed or there was some other issue, which made us have to run specific message workflows again. If we combine all message workflows in one workflow, we will lose the granular control that we currently enjoy. How do you think we should tackle this? |
@HarshKapadia2 I think this should still allow the same flexibility. catchup/.github/workflows/send-messages.yaml Lines 9 to 23 in aab8230
|
@KartikSoneji this looks good to me and thank you SO much for this amazing Pull Request, but please just give this a cursory glance and then merge it if everything seems okay to you. This makes me think, is there is way to check such CI/CD workflow changes before merging? Is building a separate testing environment the only answer? |
Nudging @KartikSoneji 🥰 |
With upcoming changes to the Twitter API, what should we do? Should we move this conversation to a an issue or a discussion? |
Let's move to an issue. |
@KartikSoneji any updates? |
This looks good to me. I'm going to merge it. Thank you so much, @KartikSoneji! |
Adds a custom js script to directly call the telegram api and send/pin messages.
Fixes issues with the markdown formatting.
Combines 4 github workflows into one.