Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: overflow of video element on screen width less than 700px #178

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

mohitgangwani
Copy link
Contributor

@mohitgangwani mohitgangwani commented Jul 31, 2023

Closes #132

The video now takes the 100% available space according to the device width, the box sizing property makes sure that the padding and margin remains intact.

Fixed issue OurTechCommunity#132. The video now takes the 100% available space according to the device width, the box sizing property makes sure that the padding and margin remains intact.
@tusharnankani
Copy link
Member

Hi @mohitgangwani
Thank you for your promptness with the PR.

A few things:

  • Edit your message and write: Fixes #<issue-number> or Closes #<issue-number>
    • This links your PR to the respective issue and automatically closes that issue, when this PR gets merged.
    • Example
  • Your PR is failing an automated check. You can read clicking Details on where it is failing.
    • Hint: It is a lint error, so it has something to do with linting. Check which file and potential fix.
    • Read more in this issue.
  • Let us know if you have checked for responsiveness and tested the fix on all devices.

@mohitgangwani
Copy link
Contributor Author

Should I close this PR and make a new one? (I am new to contributing please excuse me). I have fixed the linting errors, and tested the fix from the dev tools, it is working for devices < 700px.

@tusharnankani
Copy link
Member

Commit on this branch. We can then squash all your commits into one, before merging the PR.

image

@mohitgangwani mohitgangwani changed the title Fix: issue 132. Fix: overflow of video element on screen width less than 700 Aug 1, 2023
@mohitgangwani
Copy link
Contributor Author

Hey, I have fixed the lining issue and have edited the title.

I tested the width property to make sure it is working fine on devices with width < 700px via devtools. Works fine.

@mohitgangwani mohitgangwani changed the title Fix: overflow of video element on screen width less than 700 Fix: overflow of video element on screen width less than 700px Aug 1, 2023
Copy link
Member

@tusharnankani tusharnankani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me. Thank you for your contribution, Mohit!

@tusharnankani tusharnankani merged commit fff1ff6 into OurTechCommunity:main Aug 1, 2023
3 checks passed
@mohitgangwani mohitgangwani deleted the patch-2 branch August 2, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video element overflows on summary pages when screen width is less than 700 px.
2 participants