allow case sensitive regex matches for the MAGPIE_USER_NAME_EXTRA_REGEX setting
#594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmigneault
requested changes
Oct 25, 2023
There was a problem hiding this comment.
param_compare=re.compile(...) can be passed directly with any desired flags.
No need for the regex_flags parameter.
I like the idea of re.X being the default however, and not assume re.I by default.
All current regex used [A-Za-z] explicitly anyway, so they should still work with only re.X.
fmigneault
approved these changes
Oct 26, 2023
|
@fmigneault The tests are failing because |
|
Validated that CEDA has planned down server until November 7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that the settings/environment variable
MAGPIE_USER_NAME_EXTRA_REGEXis case sensitive.Previously, the check was case insensitive meaning that it could not be used to restrict usernames based on case.
For example, setting this value to
^[a-z]+$would have permit the username"someuser"as well as"Someuser".Now, the same regular expression will not match
"Someuser"since case sensitivity in enforced.