Skip to content

Commit

Permalink
docker: add comment reminder to remove nodejs and 'jupyter lab build'…
Browse files Browse the repository at this point in the history
  • Loading branch information
tlvu committed Dec 21, 2021
1 parent 4343030 commit ca17d14
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
4 changes: 4 additions & 0 deletions docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ RUN python -m ipykernel install --name birdy
# build jupyterlab extensions installed by conda, see `jupyter labextension list`
# Supposedly not needed with jupyterlab v3 anymore but see
# https://github.com/jupyterlab/jupyterlab/issues/11726#issuecomment-998901247
# TODO: remove 'jupyter lab build' step once all extensions move to prebuilt extensions,
# see comment https://github.com/jupyterlab/jupyterlab/issues/11726#issuecomment-998917305
# Currently jupyter-dash is holding back this step, see
# https://github.com/plotly/jupyter-dash/issues/49
RUN jupyter lab build

RUN jupyter serverextension enable voila --sys-prefix
Expand Down
2 changes: 2 additions & 0 deletions docker/environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,8 @@ dependencies:
- jupyter-dash
# Force newer nodejs for 'jupyter lab build' issue
# https://github.com/jupyterlab/jupyterlab/issues/11726#issuecomment-998901247
# TODO: remove nodejs once all extensions move to prebuilt extensions, see comment
# https://github.com/jupyterlab/jupyterlab/issues/11726#issuecomment-998917305
- nodejs >= 17.1.0
# utilities
- curl
Expand Down

0 comments on commit ca17d14

Please sign in to comment.