Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Jupyter env docker build for urlpath #112

Merged
merged 3 commits into from Dec 19, 2022
Merged

New Jupyter env docker build for urlpath #112

merged 3 commits into from Dec 19, 2022

Conversation

tlvu
Copy link
Contributor

@tlvu tlvu commented Nov 30, 2022

Overview

Full rebuild to add urlpath. Previous rebuild was #106.

Changes

<   - climpred=2.2.0=pyhd8ed1ab_0
>   - climpred=2.3.0=pyhd8ed1ab_0

<   - dask=2022.11.0=pyhd8ed1ab_0
>   - dask=2022.11.1=pyhd8ed1ab_0

<   - flox=0.6.3=pyhd8ed1ab_0
>   - flox=0.6.4=pyhd8ed1ab_0

<   - h5netcdf=1.0.2=pyhd8ed1ab_0
>   - h5netcdf=1.1.0=pyhd8ed1ab_0

<   - numpy=1.23.4=py38h7042d01_1
>   - numpy=1.23.5=py38h7042d01_0

>   - urlpath=1.2.0=pyhd8ed1ab_0

Test

Related Issue / Discussion

Additional Information

huard and others added 2 commits November 30, 2022 15:44
Conda handles larger set of dependencies than Pip so we try to stick
with Conda when we can.

Needed for the new eccc-geoapi-climate-stations.ipynb and
eccc-geoapi-xclim.ipynb from pavics-sdi repo.

See Ouranosinc/pavics-sdi#268
@tlvu tlvu requested a review from huard November 30, 2022 22:11
@huard
Copy link
Contributor

huard commented Dec 5, 2022

Trevor mentioned another library to deal with URLs (yarl), but I suggest we go ahead with urlpath for the time being. Functionalities seem very similar.

@Zeitsperre
Copy link
Collaborator

I haven't had a chance to look at it, but yarl seems be safer (non-mutable objects), and maintained. I'll work it into some existing projects first to get a sense of it. We can move from urlpath eventually.

@tlvu
Copy link
Contributor Author

tlvu commented Dec 14, 2022

@huard a build with urlpath is available on PAVICS as the alpha Jupyter image. You can try your notebooks. I'll try to close this PR for this week. All initial tests seem fine with this new build so far.

@tlvu tlvu changed the title New Jupyter env docker build New Jupyter env docker build for urlpath Dec 14, 2022
tlvu added a commit to bird-house/birdhouse-deploy that referenced this pull request Dec 14, 2022
See PR Ouranosinc/PAVICS-e2e-workflow-tests#112

- Adds `urlpath` for Ouranosinc/pavics-sdi#268, fixes Ouranosinc/PAVICS-e2e-workflow-tests#110

- Relevant changes (alphabetical order):
```diff
<   - climpred=2.2.0=pyhd8ed1ab_0
>   - climpred=2.3.0=pyhd8ed1ab_0

<   - dask=2022.11.0=pyhd8ed1ab_0
>   - dask=2022.11.1=pyhd8ed1ab_0

<   - flox=0.6.3=pyhd8ed1ab_0
>   - flox=0.6.4=pyhd8ed1ab_0

<   - h5netcdf=1.0.2=pyhd8ed1ab_0
>   - h5netcdf=1.1.0=pyhd8ed1ab_0

<   - numpy=1.23.4=py38h7042d01_1
>   - numpy=1.23.5=py38h7042d01_0

>   - urlpath=1.2.0=pyhd8ed1ab_0
```
@tlvu
Copy link
Contributor Author

tlvu commented Dec 14, 2022

@tlogan2000 @JeremyFyke FYI a new Jupyter env is coming. Delta vs the previous release is fairly small since they differ for 2 weeks only.

All standard checks are passing. I guess it should not break the various Panel dashboard we have but I have not checked. It is deployed currently as alpha image on PAVICS. Schedule to go-live this Friday.

@tlvu tlvu merged commit 08ff6dc into master Dec 19, 2022
@tlvu tlvu deleted the new-docker-build branch December 19, 2022 19:36
tlvu added a commit to bird-house/birdhouse-deploy that referenced this pull request Dec 19, 2022
See PR Ouranosinc/PAVICS-e2e-workflow-tests#112

- Adds `urlpath` for Ouranosinc/pavics-sdi#268,
fixes Ouranosinc/PAVICS-e2e-workflow-tests#110

- Relevant changes (alphabetical order):
```diff
<   - climpred=2.2.0=pyhd8ed1ab_0
>   - climpred=2.3.0=pyhd8ed1ab_0

<   - dask=2022.11.0=pyhd8ed1ab_0
>   - dask=2022.11.1=pyhd8ed1ab_0

<   - flox=0.6.3=pyhd8ed1ab_0
>   - flox=0.6.4=pyhd8ed1ab_0

<   - h5netcdf=1.0.2=pyhd8ed1ab_0
>   - h5netcdf=1.1.0=pyhd8ed1ab_0

<   - numpy=1.23.4=py38h7042d01_1
>   - numpy=1.23.5=py38h7042d01_0

>   - urlpath=1.2.0=pyhd8ed1ab_0
```
@tlvu
Copy link
Contributor Author

tlvu commented Dec 19, 2022

@tlogan2000 This new Jupyter env is live. I decided to keep the existing "previous" release in the Jupyter image drop-down menu unchanged since the change between this one and the previous release is fairly small.

@tlogan2000
Copy link
Collaborator

Excellent! Thanks @tlvu

@JeremyFyke
Copy link

Hi @tlvu - can you confirm which PAVICS version to test apps out against? the fire weather app works in internal testing but appears to error out upon deployment (tested against alpha, beta, current, and panel_dashboard).

@tlvu
Copy link
Contributor Author

tlvu commented Dec 20, 2022

Hi @tlvu - can you confirm which PAVICS version to test apps out against? the fire weather app works in internal testing but appears to error out upon deployment (tested against alpha, beta, current, and panel_dashboard).

@JeremyFyke Fixed in https://github.com/Ouranosinc/pavics_panel_cccs_deploy/pull/11

As for which image, it is the current image. You can always refer to the source of truth here https://github.com/Ouranosinc/pavics_panel_cccs_deploy/blob/4563f94944dafe83783cc3c9c12da6a027891a98/cccs-config/docker-compose-extra.yml#L56-L57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add urlpath to environment
5 participants