Add missing yaml file to package #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to add that and it didn't work.. |
aulemahal
approved these changes
Oct 4, 2023
MANIFEST.in
Outdated
| @@ -9,7 +9,7 @@ include requirements_docs.txt | |||
|
|
|||
| recursive-include figanos *.json *.mplstyle *.py *.txt | |||
| recursive-include docs *.rst conf.py Makefile make.bat *.jpg *.png *.gif | |||
| recursive-include data *.json *.txt | |||
| recursive-include data *.json *.txt *.yml | |||
There was a problem hiding this comment.
Suggested change
| recursive-include data *.json *.txt *.yml | |
| recursive-include data *.json *.txt *.yml *.png |
Shouldn't we want to add the logo too ?
There was a problem hiding this comment.
Good question. I think we should opt for a different solution. I can probably suggest an implementation tomorrow. See: #115
aulemahal
reviewed
Oct 4, 2023
juliettelavoie
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been added.What kind of change does this PR introduce?
*.yml)Does this PR introduce a breaking change?
No.
Other information: