Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc color #127

Merged
merged 22 commits into from
Oct 30, 2023
Merged

Doc color #127

merged 22 commits into from
Oct 30, 2023

Conversation

juliettelavoie
Copy link
Contributor

@juliettelavoie juliettelavoie commented Oct 26, 2023 •
edited

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • HISTORY.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Add a page for colomaps in the doc

Does this PR introduce a breaking change?

Other information:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

pre-commit-ci bot and others added 12 commits October 26, 2023 21:28
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
2a41a49 
for more information, see https://pre-commit.ci
@juliettelavoie
change position
d05f320
@juliettelavoie
Merge remote-tracking branch 'origin/doc_color' into doc_color
f188ba8 
# Conflicts:
#	docs/notebooks/figanos_colours.ipynb
@juliettelavoie
change position
d8dd78c
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c6364c8 
for more information, see https://pre-commit.ci
@juliettelavoie
docs
e5181bb
@juliettelavoie
Merge remote-tracking branch 'origin/doc_color' into doc_color
b575782
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
7b5dd5c 
for more information, see https://pre-commit.ci
@juliettelavoie
forgotten import
f2441f5
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
3d24192 
for more information, see https://pre-commit.ci
@juliettelavoie
try without trying to hide cell
6c6a070
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
cc3ccbb 
for more information, see https://pre-commit.ci
@juliettelavoie
Copy link
Contributor Author

@Zeitsperre do you know how to fix the issue with RtD ?

@juliettelavoie
Copy link
Contributor Author

Thank you !

Zeitsperre
Zeitsperre approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sarahclaude
sarahclaude approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@sarahclaude sarahclaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@juliettelavoie juliettelavoie merged commit 783d10e into main Oct 30, 2023
7 checks passed
@juliettelavoie juliettelavoie deleted the doc_color branch October 30, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

@sarahclaude sarahclaude sarahclaude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Colormap page
3 participants
@juliettelavoie @Zeitsperre @sarahclaude