Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nan edgecolor scattermap #184

Merged
merged 13 commits into from
Apr 18, 2024
Merged

Nan edgecolor scattermap #184

merged 13 commits into from
Apr 18, 2024

Conversation

sarahclaude
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • [X ] (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGES.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Xarray was able to handle NaNs but not when used with edgecolor for scatter map so masks were added

Does this PR introduce a breaking change?

No

Other information:

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@vindelico vindelico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This corrects the issue where edges where plotted where values are NaN.

@Zeitsperre Zeitsperre merged commit cc4e83a into main Apr 18, 2024
12 of 19 checks passed
@Zeitsperre Zeitsperre deleted the nan_edgecolor_scattermap branch April 18, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants