update thredds access notebook with magpie-auth active #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
huard
approved these changes
Mar 22, 2021
|
I am guessing this notebook will break without bird-house/birdhouse-deploy#107 so you'll need to sync the merge of this PR with bird-house/birdhouse-deploy#107 ? |
@tlvu |
Yes indeed, another reason to not fall behind magpie next time. |
tlvu
added a commit
that referenced
this pull request
Mar 26, 2021
…hredds" This reverts commit 6ab2ae8, reversing changes made to 947ea40. Production has not been upgraded to the broken Magpie (PR bird-house/birdhouse-deploy#107) so this revert is so that Jenkins pass again on production.
tlvu
added a commit
that referenced
this pull request
Mar 26, 2021
…magpie-to-fix-jenkins-in-production Revert "Merge pull request #209 from Ouranosinc/magpie-unauthorized-thredds" This reverts commit 6ab2ae8, reversing changes made to 947ea40. Production has not been upgraded to the broken Magpie (PR bird-house/birdhouse-deploy#107) so this revert is so that Jenkins pass again on production. Jenkins build: https://daccs-jenkins.crim.ca/job/PAVICS-e2e-workflow-tests/job/master/242/console The `finch-usage.ipynb` failure is due to bird-house/finch#161 (comment), a new Finch will be deployed to prod soon (bird-house/birdhouse-deploy#138). Otherwise, with this revert, production will be green. The original #209 is back in branch https://github.com/Ouranosinc/pavics-sdi/tree/restore-change-for-new-broken-magpie-so-we-can-test-magpie-fix so we can test new Magpie with fix. Matching PAVICS stack revert: bird-house/birdhouse-deploy#137
tlvu
added a commit
that referenced
this pull request
Apr 19, 2021
…-magpie-so-we-can-test-magpie-fix Restore pavics_thredds.ipynb change for Magpie upgrade strike II Matching PAVICS deployment PR bird-house/birdhouse-deploy#142 See original PR for more info #209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on comment identified by @tlvu
bird-house/birdhouse-deploy#107 (comment)
NB. error will not actually raise until bird-house/birdhouse-deploy#107 is integrated
preview:
https://github.com/Ouranosinc/pavics-sdi/blob/magpie-unauthorized-thredds/docs/source/notebooks/pavics_thredds.ipynb