Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pykdtree to environment to resolve cartopy bug arising from scipy 1.11 #298

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

huard
Copy link
Contributor

@huard huard commented Jul 6, 2023

Fixes #294

@huard huard requested a review from tlvu July 6, 2023 19:15
@huard
Copy link
Contributor Author

huard commented Jul 6, 2023

@Zeitsperre FYI, you might see this elsewhere.

Copy link
Contributor

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the notebook breaking here too, then good for me. For the breakage in the Jupyter env, the fix has to be applied to the Jupyter env, not here, I can take care of this.

tlvu added a commit to Ouranosinc/PAVICS-e2e-workflow-tests that referenced this pull request Jul 6, 2023
@huard
Copy link
Contributor Author

huard commented Jul 6, 2023

The notebooks are not executed in this repo. They're just rendered to HTML...

The size of the image required to run the nbs is too large to host on RtD I believe. Ideally we would have an Action that "submits" the nbs to kernels launched from the different images.

@huard huard merged commit 3be89d6 into master Jul 6, 2023
2 checks passed
@huard huard deleted the fix-294 branch July 6, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WMS_example: "ValueError: 'x' must be finite, check for nan or inf values" with new Jupyter env
2 participants