Add analogs notebook data to main branch #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aulemahal
approved these changes
Sep 12, 2023
|
@Ouranosinc/xclim-core In order to prevent the existing SDBA notebook tests from outright failing in a clean environment, I'll be keeping this branch open, at least for a few releases (or until 2024?). As a reminder, all testing data fetched from branches should be merged to the See: https://xclim.readthedocs.io/en/stable/contributing.html#updating-testing-data for more information |
5 tasks
Zeitsperre
added a commit
to Ouranosinc/xclim
that referenced
this pull request
Sep 12, 2023
### What kind of change does this PR introduce? * Adds `pytest-socket` to the testing dependencies, in order to block HTTP requests * Adds a new pytest marker `"requires_internet"` for tests that absolutely depend on internet access. * Fixed an error in the pytest configuration that impeded copying of testing data to thread safe caches of workers (this should always occur). * Added handling for `pytest-socket`'s `SocketBlockedError` when attempting to fetch md5 validation files for cached testing data. * Added a `tox` modifier for running tests without internet access (`tox -e offline`) * Option to call `tox -e offline-prefetch` to run the data prefetching command before sockets are disabled in `pytest` call. * Added a build using Python3.10 to the GitHub Workflows that uses the new `offline` modifier in the `tox` configuration. * For better accuracy, the `tox -e black` recipe has been renamed to `tox -e lint`, as this configuration already included several other linting checks. * Added a CLI command (`$ xclim prefetch_testing_data`) for manually calling the `populate_testing_data()` command with branch (`--branch/-b`) options. * Updated the testing data used in the `analogs.ipynb` notebook to use the testing data now found in `Ouranosinc/xclim-testdata`'s main branch (see: Ouranosinc/xclim-testdata#26) `xclim` now has a dedicated CLI command for prefetching the `Ouranosinc/xclim-testdata`: ``` $ xclim prefetch_testing_data # or, for a specific testdata branch $ xclim prefetch_testing_data --branch my_testdata_branch ``` Running `pytest` will still perform the fetching of data on first run if the user does not have an `xclim-testdata` folder in their platform-dependent cache location (`/home/$USER/.cache/xclim-testdata` on Linux). ### Does this PR introduce a breaking change? Yes: * `tox` is now configured to pass positional arguments to the `pytest` calls directly. This gives developers much more control when selecting/deselecting `pytest` markers. To replicate previous behaviour (skipping `slow` tests), most `tox` invocations should resemble the following: ``` $ tox -e pyXYZ -- -m "not slow" ``` * `xclim` development now requires the `pytest-socket` plugin (has been explicitly added to the development requirements). This plugin allows developers to mimic being `offline` when testing new `xclim` features or bug fixes, if they so choose. * For better accuracy, the `tox -e black` recipe has been renamed to `tox -e lint`, as this configuration already included several other linting checks. ### Other information: https://github.com/miketheman/pytest-socket https://tox.wiki/en/latest/config.html#substitutions-for-positional-arguments-in-commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.md5checksum file generated withmake_check_sums.pyThis dataset is typically fetched when running tests from the
xclimmaster branch, but it should be available withinmainand subsequent tags for the sake of consistency.