You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It should not be possible to set a call signature within an indice with Quantified without also specifying the dimensions for it within the declare_units decorator. This causes problems with Indicator parameters and feels like an undocumented "gotcha".
e.g. wo in the following call signature should be [length]:
Make sure all Quantified parameters with a default value declare their
dimension.
<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
- This PR fixes#1293
- [x] Tests for the changes have been added (for bug fixes / features)
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGES.rst has been updated (with summary of main changes)
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added
### What kind of change does this PR introduce?
* Add sanity check in declare_units.
### Does this PR introduce a breaking change?
No
### Other information:
Ran into this issue in #1235
It should not be possible to set a call signature within an
indice
withQuantified
without also specifying the dimensions for it within thedeclare_units
decorator. This causes problems with Indicator parameters and feels like an undocumented "gotcha".e.g.
wo
in the following call signature should be[length]
:The text was updated successfully, but these errors were encountered: