Snow season length is not a season length #1703
Assignees
Labels
bug
Something isn't working
indicators
Climate indices and indicators
invalid
This doesn't seem right
Milestone
Comments
aulemahal
added
bug
aulemahal
added a commit
that referenced
this issue
Apr 18, 2024
<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
- This PR fixes #1703
- [x] Tests for the changes have been added (for bug fixes / features)
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGES.rst has been updated (with summary of main changes)
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added
### What kind of change does this PR introduce?
* Renames old `sn[dw]_season_length` to `sn[dw]_days_above`, which
better reflects what they actually do.
* Implement `sn[dw]_season_length` as an actual season length :
duraction between a start and an end, both defined as the first day of a
period of minimum length continuously above/under a given threshold.
* Rephrase the documentation of these indicators and of the start/end
variants.
* Update the threshold of `snw`, like we said we'd do in 0.47 (youpsi).
### Does this PR introduce a breaking change?
Yes. An indicator name now points to another computation.
### Other information:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Snow season length indicators (
snd_season_length,snw_season_length) are counting the number of days with snow, without the "season" notion (windowed run at the start and the end).xclim/xclim/indices/_threshold.py
Line 2141 in cea510b
xclim/xclim/indices/_threshold.py
Line 2104 in cea510b
The text was updated successfully, but these errors were encountered: