Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouper limited to datetime properties and coordinates #1736

Open
aulemahal opened this issue Apr 29, 2024 · 0 comments
Open

Grouper limited to datetime properties and coordinates #1736

aulemahal opened this issue Apr 29, 2024 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed sdba Issues concerning the sdba submodule.
Milestone

Comments

@aulemahal
Copy link
Collaborator

aulemahal commented Apr 29, 2024

Current sdba.Grouper is limited to datetime properties like 'time.month', 'time.dayofyear'. Passing the name of an integer coordinate doesn't work.

Originally posted by @jamaa in #1735

Datetime-assumptions issues:

  • Grouper(dim_name) doesn't actually group on values of the dim, it groups all values of the dim together : like Group('time') does. But it is kinda unexpected with integer dimensions.
  • Grouper('time.<aux coord>') should work when the time grouping is not one of the classical "day of year", "month" or "week", but rather a custom provided integer auxiliary coord.
  • The adjustment input checks will fail if the grouping dimension does not have a calendar. Which means only datetime coordinates are usable.
@aulemahal aulemahal self-assigned this Apr 29, 2024
@aulemahal aulemahal added bug Something isn't working enhancement New feature or request sdba Issues concerning the sdba submodule. docs Improvements to documenation and removed docs Improvements to documenation labels Apr 29, 2024
@aulemahal aulemahal added this to the Summer 2024 milestone Apr 29, 2024
@aulemahal aulemahal changed the title Grouper limited to datetime properties. Grouper limited to datetime properties and coordinates Apr 29, 2024
@aulemahal aulemahal added the help wanted Extra attention is needed label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed sdba Issues concerning the sdba submodule.
Projects
None yet
Development

No branches or pull requests

1 participant