Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning xclim function with ETCCDI definition. #848

Closed
lpcaron opened this issue Sep 23, 2021 · 3 comments
Closed

Aligning xclim function with ETCCDI definition. #848

lpcaron opened this issue Sep 23, 2021 · 3 comments
Assignees

Comments

@lpcaron
Copy link

lpcaron commented Sep 23, 2021

A request from CCDP PWG:

Two wet day indices on ClimateData.ca (XClim) use > rather than >= (ETCCDI) in the definition.

Would it be possible to change the default option in xclim such that the definition is consistent with ETCCDI?

@Zeitsperre
Copy link
Collaborator

That would be a fairly breaking change. We already have the wet days (RR1) indicator using the ICCLIM definition for wet days (https://xclim.readthedocs.io/en/stable/indicators_api.html?highlight=icclim#xclim.indicators.icclim.RR1). Why not suggest they use that by default?

@aulemahal
Copy link
Collaborator

In xclim, the wetdays indicator already uses >=. On thredds, I randomly checked 2 netCDF files in the cccs_portal folder, for r1mm et r20mm. Both have metadata saying that >= was used.
I might have missed something, but it might also be that the documentation on the portal is not exact?

@tlogan2000
Copy link
Collaborator

@aulemahal @Zeitsperre Thanks, I think this is probably a case where the website data descriptions have simply not identically followed the metadata fields. @lpcaron I will close the issue here and we can follow up with the CCDP project collaborators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants