Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace sklearn by numpy in sdba.measures #1051

Merged
merged 3 commits into from Apr 8, 2022
Merged

replace sklearn by numpy in sdba.measures #1051

merged 3 commits into from Apr 8, 2022

Conversation

juliettelavoie
Copy link
Contributor

@juliettelavoie juliettelavoie commented Apr 8, 2022 •
edited

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added
  • bumpversion patch has been called on this branch
  • The relevant author information has been added to .zenodo.json

What kind of change does this PR introduce?

I replace th sklearn functions in sdba.measures.rmse and sdba.measures.mae by their numpy equivalent. This improves the performance with dask.

Does this PR introduce a breaking change?

No

Other information:

@coveralls
Copy link

coveralls commented Apr 8, 2022 •
edited

Coverage Status

Coverage increased (+0.01%) to 91.595% when pulling ad0b5c0 on fix-sklearn_measures into e6f803c on master.

Zeitsperre
Zeitsperre reviewed Apr 8, 2022
View reviewed changes
HISTORY.rst Outdated Show resolved Hide resolved
@juliettelavoie @Zeitsperre
Update HISTORY.rst
db28b46 
Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
aulemahal
aulemahal approved these changes Apr 8, 2022
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@juliettelavoie juliettelavoie merged commit 5cd9d79 into master Apr 8, 2022
@juliettelavoie juliettelavoie deleted the fix-sklearn_measures branch April 8, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre left review comments

@aulemahal aulemahal aulemahal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@juliettelavoie @coveralls @Zeitsperre @aulemahal