Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation adjustments #1233

Merged
merged 27 commits into from Nov 30, 2022
Merged

Documentation adjustments #1233

merged 27 commits into from Nov 30, 2022

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Nov 10, 2022

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Links the README.rst directly into the sphinx documentation so that we only need to update our front matter in one file
  • Changes our badge layout for better readability
  • Modifies the toctree in conf for better section layout
  • Some small changes applied to section titles
  • pre-commit autoupdate run
  • Adds nbqa to the dev requirements for running black over notebooks

Does this PR introduce a breaking change?

Somewhat. nbqa is added as a dev requirement for make lint recipe.

Other information:

@Zeitsperre Zeitsperre added this to the v0.40 milestone Nov 10, 2022
@Zeitsperre Zeitsperre self-assigned this Nov 10, 2022
@github-actions github-actions bot added the docs Improvements to documenation label Nov 10, 2022
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theses changes look good to me!

Sphinx is having some difficulties on RTD though, strange since your changes are quite small...

@github-actions github-actions bot added the approved Approved for additional tests label Nov 11, 2022
@Zeitsperre Zeitsperre added approved Approved for additional tests and removed approved Approved for additional tests labels Nov 11, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.202% when pulling 26be037 on readme_changes into 87dac2b on master.

@github-actions github-actions bot added the CI Automation and Contiunous Integration label Nov 11, 2022
@Zeitsperre Zeitsperre changed the base branch from master to fix_docs-recipe November 28, 2022 18:10
@github-actions github-actions bot removed the CI Automation and Contiunous Integration label Nov 29, 2022
@Zeitsperre
Copy link
Collaborator Author

Problem finally solved:

It turns out that sphinx linkcheck launches requests for all the contents of every link that is requested, therefore any links to pages with lots of hyperlinks and elements will be very heavy. This is solved for us here by ignoring links on the ReadMe, which is fine.

Will perform a squash commit to remove the awful history here once build clears.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the CI Automation and Contiunous Integration label Nov 30, 2022
@Zeitsperre Zeitsperre merged commit 7566bef into fix_docs-recipe Nov 30, 2022
@Zeitsperre Zeitsperre deleted the readme_changes branch November 30, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests CI Automation and Contiunous Integration docs Improvements to documenation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants