Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dataflag checks for relevant variables #1241

Merged
merged 5 commits into from Nov 16, 2022
Merged

add dataflag checks for relevant variables #1241

merged 5 commits into from Nov 16, 2022

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Nov 11, 2022 •
edited

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Adds relevant dataflag checks for potential evaporation, air pressure at sea level, and convective precipitation

Does this PR introduce a breaking change?

Nope.

Other information:

@Zeitsperre Zeitsperre added the standards / conventions Suggestions on ways forward label Nov 11, 2022
@Zeitsperre Zeitsperre added this to the v0.40 milestone Nov 11, 2022
@Zeitsperre Zeitsperre self-assigned this Nov 11, 2022
@github-actions github-actions bot added the indicators Climate indices and indicators label Nov 11, 2022
aulemahal
aulemahal approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much changes, good.

@github-actions github-actions bot added the approved Approved for additional tests label Nov 16, 2022
@Zeitsperre Zeitsperre merged commit 33655eb into master Nov 16, 2022
@Zeitsperre Zeitsperre deleted the variable_checks branch November 16, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
approved Approved for additional tests indicators Climate indices and indicators standards / conventions Suggestions on ways forward
Projects
None yet
Milestone
v0.40
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zeitsperre @aulemahal