Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Alavoine and Grenier 2022 article #1247

Merged
merged 5 commits into from Nov 16, 2022
Merged

Update Alavoine and Grenier 2022 article #1247

merged 5 commits into from Nov 16, 2022

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Nov 16, 2022 •
edited

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Updates Alavoine and Grenier article reference
  • Cleans up a few dosctrings in the SDBA module
  • Updates bibtex urls to use HTTPS where possible

Does this PR introduce a breaking change?

Nope.

Other information:

@Zeitsperre Zeitsperre added the docs Improvements to documenation label Nov 16, 2022
@Zeitsperre Zeitsperre added this to the v0.40 milestone Nov 16, 2022
@Zeitsperre Zeitsperre self-assigned this Nov 16, 2022
@github-actions github-actions bot added the sdba Issues concerning the sdba submodule. label Nov 16, 2022
@github-actions github-actions bot added the approved Approved for additional tests label Nov 16, 2022
@coveralls
Copy link

coveralls commented Nov 16, 2022 •
edited

Coverage Status

Coverage remained the same at 92.222% when pulling dd69cf3 on update_article_ref into b1b6754 on master.

@Zeitsperre Zeitsperre merged commit f90ae93 into master Nov 16, 2022
@Zeitsperre Zeitsperre deleted the update_article_ref branch November 16, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huard huard huard approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
approved Approved for additional tests docs Improvements to documenation sdba Issues concerning the sdba submodule.
Projects
None yet
Milestone
v0.40
Development

Successfully merging this pull request may close these issues.

Update bibtex with published paper
3 participants
@Zeitsperre @coveralls @huard