Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reordering logic in MBCn example #1250

Merged
merged 6 commits into from Dec 9, 2022
Merged

Fix reordering logic in MBCn example #1250

merged 6 commits into from Dec 9, 2022

Conversation

aulemahal
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • The MBCn example was doing it wrong. The NpdfT output was being reordered according to the initial adjustment, while the opposite is supposed to be done. I also renamed some variables in a way I think is clearer.

Does this PR introduce a breaking change?

No.

Other information:

@aulemahal aulemahal requested a review from huard November 24, 2022 21:42
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added the docs Improvements to documenation label Nov 24, 2022
@github-actions github-actions bot added the approved Approved for additional tests label Nov 24, 2022
@aulemahal
Copy link
Collaborator Author

@Zeitsperre There's black magic going on here.
The build hung on the test that does have a skip decorator........

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.995% when pulling 7f91109 on fix-mbcn-doc into 51bb58a on master.

@aulemahal aulemahal merged commit 503c506 into master Dec 9, 2022
@aulemahal aulemahal deleted the fix-mbcn-doc branch December 9, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huard huard huard approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests docs Improvements to documenation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MBCn reordering (xclim.sdba.processing.reordering)
4 participants
@aulemahal @coveralls @huard @Zeitsperre