Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some docs examples, add formula for growing_season_end #1266

Merged
merged 3 commits into from Jan 11, 2023
Merged

Fix some docs examples, add formula for growing_season_end #1266

merged 3 commits into from Jan 11, 2023

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Jan 10, 2023 •
edited

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Fixes some malformed doctests
  • Adds the formula for growing_season_end

Does this PR introduce a breaking change?

No.

Other information:

@Zeitsperre Zeitsperre added the bug Something isn't working label Jan 10, 2023
@Zeitsperre Zeitsperre added this to the v0.40 milestone Jan 10, 2023
@Zeitsperre Zeitsperre self-assigned this Jan 10, 2023
@github-actions github-actions bot added the indicators Climate indices and indicators label Jan 10, 2023
@Zeitsperre Zeitsperre changed the title fix some examples, add formula for growing_season_end Fix some docs examples, add formula for growing_season_end Jan 10, 2023
@github-actions github-actions bot added the approved Approved for additional tests label Jan 11, 2023
@coveralls
Copy link

Coverage Status

Coverage: 92.483%. Remained the same when pulling a277b63 on fix_doc_example into 4cb1d25 on master.

@Zeitsperre Zeitsperre merged commit c16cb06 into master Jan 11, 2023
@Zeitsperre Zeitsperre deleted the fix_doc_example branch January 11, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlogan2000 tlogan2000 tlogan2000 approved these changes

@aulemahal aulemahal Awaiting requested review from aulemahal

Assignees

@Zeitsperre Zeitsperre

Labels
approved Approved for additional tests bug Something isn't working indicators Climate indices and indicators
Projects
None yet
Milestone
v0.40
Development

Successfully merging this pull request may close these issues.

DOCS: Example not rendered correctly
3 participants
@Zeitsperre @coveralls @tlogan2000