New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snow and radiation conversion, indicator translation fixes #1271
Conversation
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While looking up the CF standard for rlus
and family, I realized we were not using the same vocabulary... I think we should go for CF:
"surface downwelling shortwave flux" instead of "surface downwards solar radiation", and so on.
"Downwards" sound like a direction, while "downwelling" also has a meaning of source.
For snow conversion, I don't think these are "approximations". I would rename:
snow_amount_approximation -> snow_amount
snow_depth approximation -> snow_depth
snow_depth -> snow_depth_mean
(sry)
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
for more information, see https://pre-commit.ci
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
snow_depth_from amount
andsnow_amount_from_depth
) for converting between snow amount and snow depth (with the aid of snow density).longwave_radiation_upwards_from_net_downwards
andshortwave_radiation_upwards_from_net_downwards
) for determiningrlus
fromrls
andrlds
, as well asrsus
fromrss
andrsds
, respectively.[power]
unit definition for radiation-based variables.test_xclim_translations
.kbdi
,df
,ffdi
and fixed broken translations forcffwis
andjetstream_metric_woolings
.Does this PR introduce a breaking change?
No.
Other information:
See: Ouranosinc/miranda#106