Add snow water cover indices #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeitsperre
reviewed
Jan 18, 2023
|
Ignore the license failure. Already resolved. |
3 tasks
…_snow_water_cover_indices
…anosinc/xclim into add_snow_water_cover_indices
aulemahal
reviewed
Feb 13, 2023
There was a problem hiding this comment.
Few comments on the metadata. The code looks good.
I think we need a clearer syntax for constructing indicators metadata.
When we get to a point where most basic indicators like these can be constructed from generic functions, having explicit names (rather than poetic) will be a plus. Thus, I am wondering if we could rename these like:
continuous_snow_amount_cover_start -> snw_season_start
snow_depth_cover_duration -> snd_season_length
etc
Where season has this "long spell with small holes" meaning, like in the rest of xclim.
This is a suggestion, we might need to discuss it in the meeting tomorrow.
Zeitsperre
force-pushed
the
add_snow_water_cover_indices
branch
from
ebe0cbb
to
3e94150
Compare
* added a constant mean snow density from [Sturm et. al, 2010](https://journals.ametsoc.org/view/journals/hydr/11/6/2010jhm1202_1.xml)
…anosinc/xclim into add_snow_water_cover_indices
Zeitsperre
reviewed
Feb 27, 2023
|
Should I leave |
…anosinc/xclim into add_snow_water_cover_indices
Zeitsperre
approved these changes
Feb 27, 2023
Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
english 2/2 Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
…anosinc/xclim into add_snow_water_cover_indices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been addedWhat kind of change does this PR introduce?
Does this PR introduce a breaking change?
Other information: